Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notes): remove duplicate env var in release notes for clusterIP mode #137

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix(notes): remove duplicate env var in release notes for clusterIP mode #137

merged 1 commit into from
Apr 22, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Apr 22, 2024

Related to #110

Remove duplicate env var in release note for deployment patching command.

Before

kubectl -n myns set env deploy --containers=cryostat cryostat QUARKUS_HTTP_HOST=$CRYOSTAT_WEB_HOST QUARKUS_HTTP_HOST=$CRYOSTAT_WEB_HOST STORAGE_EXT_URL=http://$CRYOSTAT_WEB_HOST:8080/storage/ GRAFANA_DASHBOARD_EXT_URL=http://$CRYOSTAT_WEB_HOST:8080/grafana/

After

kubectl -n myns set env deploy --containers=cryostat cryostat QUARKUS_HTTP_HOST=$CRYOSTAT_WEB_HOST STORAGE_EXT_URL=http://$CRYOSTAT_WEB_HOST:8080/storage/ GRAFANA_DASHBOARD_EXT_URL=http://$CRYOSTAT_WEB_HOST:8080/grafana/

@tthvo tthvo requested a review from a team April 22, 2024 11:38
@andrewazores andrewazores merged commit c4eb3c5 into cryostatio:cryostat3 Apr 22, 2024
2 checks passed
@tthvo tthvo deleted the release-note-fix branch April 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
fix safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores