Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#65 Separate components from IntlProvider dependency #66

Merged
merged 12 commits into from
Apr 26, 2023
Merged

#65 Separate components from IntlProvider dependency #66

merged 12 commits into from
Apr 26, 2023

Conversation

fbeceic
Copy link
Collaborator

@fbeceic fbeceic commented Mar 6, 2023

Basic information

  • Tiller version: 1.3.0
  • Module: intl

Description

  • exclude IntlProvider as direct dependency for components where possible
  • set up defaults for components if IntlProvider is not present

Related issue

Closes #65

Types of changes

  • Visual improvements (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's Prettier code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added a story to cover my changes
  • All new and existing story tests pass

@fbeceic fbeceic requested a review from jtomic-croz March 6, 2023 08:36
jtomic-croz
jtomic-croz reviewed Mar 6, 2023
View reviewed changes
libs/intl/src/intlDictionary.js Outdated Show resolved Hide resolved
libs/intl/src/useIntlContext.tsx Outdated Show resolved Hide resolved
libs/intl/src/useLabel.tsx Outdated Show resolved Hide resolved
@fbeceic fbeceic changed the title #65 WIP: Separate components from IntlProvider dependency #65 Separate components from IntlProvider dependency Mar 8, 2023
jtomic-croz
jtomic-croz reviewed Apr 25, 2023
View reviewed changes
libs/core/src/Pagination.tsx Show resolved Hide resolved
libs/date/src/Date.tsx Outdated Show resolved Hide resolved
libs/intl/src/useIntlContext.tsx Outdated Show resolved Hide resolved
libs/form-elements/src/FieldGroup.tsx Show resolved Hide resolved
libs/form-elements/src/NumberInput.tsx Outdated Show resolved Hide resolved
libs/intl/src/Intl.tsx Outdated Show resolved Hide resolved
storybook/src/date/Date.stories.tsx Outdated Show resolved Hide resolved
@jtomic-croz jtomic-croz merged commit 9da6342 into master Apr 26, 2023
@fbeceic fbeceic deleted the task/65 branch April 26, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtomic-croz jtomic-croz jtomic-croz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IntlProvider as required wrapper where possible
2 participants
@fbeceic @jtomic-croz