Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IntlProvider as required wrapper where possible #65

Closed
fbeceic opened this issue Mar 3, 2023 · 0 comments · Fixed by #66
Closed

Remove IntlProvider as required wrapper where possible #65

fbeceic opened this issue Mar 3, 2023 · 0 comments · Fixed by #66
Assignees
@fbeceic
Labels
enhancement New feature or request

Comments

@fbeceic
Copy link
Collaborator

fbeceic commented Mar 3, 2023

Basic information

  • Tiller version: 1.3.0
  • Module: intl

Enhancement description

Get rid of Intl(Provider) dependency on components where it's achievable to reduce the number of components that require it for functioning. Set defaults on those components without requiring IntlProvider.

Current behaviour

Current list of components that require Intl(Provider) for functioning:

  • Amount
  • CheckboxGroup(field)
  • Date
  • DateInput(field)
  • DatePicker
  • DateRangeInput(field)
  • DateTimeInput(field)
  • TimeInput(field)
  • DragZone(field)
  • Input(field)
  • Login
  • Number
  • NumberInput(field)
  • RadioGroup(field)
  • Select(field)
  • Slider(field)
  • Textarea(field)
  • Toggle(field)
  • TreeSelect(field)

Wanted behaviour

Reduce the list above as much as possible so that components can be used without Intl(Provider).
@fbeceic fbeceic added the enhancement New feature or request label Mar 3, 2023
@fbeceic fbeceic self-assigned this Mar 3, 2023
fbeceic pushed a commit that referenced this issue Mar 6, 2023
#65 Refactor useIntlContext
4ae047e
fbeceic pushed a commit that referenced this issue Mar 6, 2023
#65 Refactor Pagination to include Intl
211542b
fbeceic pushed a commit that referenced this issue Mar 6, 2023
#65 Refactor useLabel to exclude Intl if not present
5fd896b
@fbeceic fbeceic mentioned this issue Mar 6, 2023
Merged
9 tasks
fbeceic pushed a commit that referenced this issue Mar 6, 2023
#65 Add fallback to useLabel, improve naming
e6d7664
fbeceic pushed a commit that referenced this issue Mar 8, 2023
#65 Refactor Date
aa9e073
fbeceic pushed a commit that referenced this issue Mar 8, 2023
#65 Improve Intl utilities & extend intlDictionary
1edbd6e
fbeceic pushed a commit that referenced this issue Mar 8, 2023
#65 Improve IntlProvider independence for date inputs
78dd640
fbeceic pushed a commit that referenced this issue Mar 8, 2023
#65 Improve IntlProvider independence for remaining components
50b6a72
fbeceic pushed a commit that referenced this issue Mar 8, 2023
#65 Update docs
3fbe4f1
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Refactor useIntlContext
a083d29
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Refactor Pagination to include Intl
57ae1ff
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Refactor useLabel to exclude Intl if not present
c05cedd
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Add fallback to useLabel, improve naming
73a8af9
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Refactor Date
7a4bedd
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Improve Intl utilities & extend intlDictionary
9014432
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Improve IntlProvider independence for date inputs
69a430d
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Improve IntlProvider independence for remaining components
66e9f3f
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Update docs
7390441
fbeceic pushed a commit that referenced this issue Apr 24, 2023
#65 Add autocompleteAddItem key to defaultKeyConfig
ee65872
fbeceic pushed a commit that referenced this issue Apr 26, 2023
#65 Improve NumberInput, useIntlContext and docs
3902cf8
fbeceic pushed a commit that referenced this issue Apr 26, 2023
#65 Improve Date component
c4e63b0
jtomic-croz pushed a commit that referenced this issue Apr 26, 2023
@fbeceic
#65 Separate components from IntlProvider dependency (#66)
9da6342 
* #65 Refactor useIntlContext

* #65 Refactor Pagination to include Intl

* #65 Refactor useLabel to exclude Intl if not present

* #65 Add fallback to useLabel, improve naming

* #65 Refactor Date

* #65 Improve Intl utilities & extend intlDictionary

* #65 Improve IntlProvider independence for date inputs

* #65 Improve IntlProvider independence for remaining components

* #65 Update docs

* #65 Add autocompleteAddItem key to defaultKeyConfig

* #65 Improve NumberInput, useIntlContext and docs

* #65 Improve Date component

---------

Co-authored-by: Felix Beceic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbeceic fbeceic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#65 Separate components from IntlProvider dependency croz-ltd/tiller
1 participant
@fbeceic