Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#287 Extend type of title prop on TopNavigation and SidebarNavigation #290

Merged
merged 1 commit into from
Dec 17, 2024
Merged

#287 Extend type of title prop on TopNavigation and SidebarNavigation #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/menu/src/SidebarNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ type SidebarNavigationItemProps = {
* Defines the title of the item. If the 'isExpandable' prop is not set to true (which is by default),
* this prop is not required. In that case, you can set the title via the 'children' prop.
*/
title?: string;
title?: React.ReactNode;

/**
* Custom additional class name for the main container component.
Expand Down Expand Up @@ -147,7 +147,7 @@ type SidebarNavigationDropdownProps = {
/**
* Title of the Dropdown menu, shown only if text variant of the dropdown is selected.
*/
title: string;
title: React.ReactNode;

/**
* Determines the button color for the dropdown. Accepts many colors, along with your brand colors
Expand Down
4 changes: 2 additions & 2 deletions libs/menu/src/TopNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export type TopNavigationItemProps = {
* Defines the title of the item. If the 'isExpandable' prop is not set to true (which is by default),
* this prop is not required. In that case, you can set the title via the 'children' prop.
*/
title?: string;
title?: React.ReactNode;

/**
* Destination url.
Expand Down Expand Up @@ -148,7 +148,7 @@ type TopNavigationDropdownProps = {
/**
* Title of the Dropdown menu, shown only if text variant of the dropdown is selected.
*/
title: string;
title: React.ReactNode;

/**
* Custom icon serving as a dropdown menu open button.
Expand Down