Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#287 Extend type of title prop on TopNavigation and SidebarNavigation #290

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

fbeceic
Copy link
Collaborator

@fbeceic fbeceic commented Dec 17, 2024

Basic information

  • Tiller version: 1.15.1
  • Module: menu

Description

Summary

Expanded title prop on TopNavigation and SidebarNavigation components by changing its type:

  • Old type - string
  • New type - React.ReactNode

Related issue

#287

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's Prettier code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added a story to cover my changes
  • All new and existing story tests pass

@fbeceic fbeceic requested a review from jtomic-croz December 17, 2024 10:27
@fbeceic fbeceic added the enhancement New feature or request label Dec 17, 2024
@fbeceic fbeceic changed the title Extend type of title prop on TopNavigation and SidebarNavigation #287 Extend type of title prop on TopNavigation and SidebarNavigation Dec 17, 2024
@jtomic-croz jtomic-croz merged commit fc7d60f into master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants