Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160 Fix visibleItemCount consistency for DropdownMenu component #162

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

fbeceic
Copy link
Collaborator

@fbeceic fbeceic commented Dec 20, 2023

Basic information

  • Tiller version: 1.7.3
  • Module: menu

Description

Fixed visibleItemCount prop consistency when changing values for DropdownMenu component.

Related issue

Closes #160

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's Prettier code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added a story to cover my changes
  • All new and existing story tests pass

@fbeceic fbeceic requested review from ivam5 and jtomic-croz December 20, 2023 13:21
@fbeceic fbeceic self-assigned this Dec 20, 2023
@fbeceic fbeceic changed the title #160 Fix visibleItemCount consistency for DropdownMenu component #160 Fix visibleItemCount consistency for DropdownMenu component Dec 20, 2023
@jtomic-croz jtomic-croz merged commit d48fa7c into master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DropdownMenu - visibleItemCount prop problems
2 participants