Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownMenu - visibleItemCount prop problems #160

Closed
fbeceic opened this issue Dec 20, 2023 · 0 comments · Fixed by #162
Closed

DropdownMenu - visibleItemCount prop problems #160

fbeceic opened this issue Dec 20, 2023 · 0 comments · Fixed by #162
Assignees
Labels
bug Something isn't working

Comments

@fbeceic
Copy link
Collaborator

fbeceic commented Dec 20, 2023

Basic information

  • Tiller version:
    1.7.3

Bug description

If visibleItemCount is set to a length larger then the length of the items the height appears as if there are that many items inside the menu:
image

Also, when the visibleItemCount is updated from its initial value, the component doesn't update its state to the newer value, but rather resorts to the initial one.

Expected behavior

The component adjusts its height properly and updates its state if the prop visibleItemCount changes.

Actual behavior

The component doesn't account for edge cases and sometimes sets its height wrong. Also, it doesn't track the visibleItemCount prop properly.

@fbeceic fbeceic added the bug Something isn't working label Dec 20, 2023
@fbeceic fbeceic self-assigned this Dec 20, 2023
@fbeceic fbeceic changed the title DropdownMenu - visibleItemCount prop problems DropdownMenu - visibleItemCount prop problems Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant