Add the Header Go template variable to setup.go.tmpl
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
requested review from
ulucinar,
erhancagirici and
mergenci
as code owners
sergenyalcin
changed the title
Header Go template variable to setup.go.tmpl
ulucinar
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. Let's update the open provider Azure & AzureAD PRs. We can open new PRs for AWS & GCP tomorrow.
|
Successfully created backport PR #377 for |
|
Successfully created backport PR #378 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the
HeaderGo template variable tosetup.go.tmplto generate the license headers to generated setup go files. Now we do not have this and after moving the license statements from tmpl files in this PR, we do not generate these statements.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested in this PR locally.