Move license statements to separate files (for tmpl files) to prevent license statement duplication #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
requested review from
ulucinar,
erhancagirici and
mergenci
as code owners
…t duplication Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
move-license-statements-tmpl
branch
from
b6482e7
to
a648048
Compare
ulucinar
approved these changes
Mar 14, 2024
Signed-off-by: Sergen Yalçın <[email protected]>
|
Successfully created backport PR #374 for |
|
Successfully created backport PR #375 for |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR moves license statements to separate files (for tmpl files) to prevent license statement duplication.
We have injected the license statements from the providers during generation. If we explicitly add the license statements to the tmpl files, related license lines are being generate as duplicate. This PR prevents this duplication.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested in crossplane-contrib/provider-upjet-azuread#111