Updates source code for ownership change #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanduplessis
force-pushed
the
ownership_change
branch
4 times, most recently
from
4241d4c
to
e4c213a
Compare
jeanduplessis
force-pushed
the
ownership_change
branch
13 times, most recently
from
fd6d216
to
6ac388a
Compare
jeanduplessis
force-pushed
the
ownership_change
branch
from
c94576c
to
a0029fb
Compare
Signed-off-by: Jean du Plessis <[email protected]>
jeanduplessis
force-pushed
the
ownership_change
branch
from
a0029fb
to
ba13938
Compare
|
@ulucinar @sergenyalcin, as maintainers of the project, please indicate your acceptance of this code ownership change. |
sergenyalcin
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
There are some yaml formatting in this file. But I think it will not affect the functionality.
|
|
||
| go 1.20 | ||
|
|
||
| require ( | ||
| dario.cat/mergo v1.0.0 | ||
| github.com/antchfx/htmlquery v1.2.4 | ||
| github.com/crossplane/crossplane v1.10.0 | ||
| github.com/crossplane/crossplane-runtime v0.20.0 | ||
| github.com/crossplane/crossplane v1.13.2 |
There was a problem hiding this comment.
It seems that our crossplane dependencies are a bit old and updating them make sense to me. However, while switching to new architecture, protecting the versions may also be considered. What are your thoughts @jeanduplessis @ulucinar
| @@ -18,7 +22,7 @@ func FilterDescription(description, keyword string) string { | |||
| } | |||
| } | |||
| if len(result) == 0 { | |||
| return strings.ReplaceAll(strings.ToLower(description), keyword, "Upbound official provider") | |||
| return strings.ReplaceAll(strings.ToLower(description), keyword, "provider") | |||
There was a problem hiding this comment.
nit:
Suggested change
| return strings.ReplaceAll(strings.ToLower(description), keyword, "provider") | |
| return strings.ReplaceAll(strings.ToLower(description), keyword, "crossplane provider") |
ulucinar
approved these changes
Oct 11, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR prepares the repo for ownership transfer to github.com/crossplane
Project name: Upjet
Destination repo: crossplane/upjet
CI/CD pipeline: Does not depend on Upbound specific code or infrastructure
Preparation tasks
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested