Applying license changes #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
licence-updates
branch
from
f518a17
to
ce9b651
Compare
ulucinar
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. Looks like we are missing the license headers for the generated example manifests (they have always been missing) because upjet's example manifest generation pipeline does not generate them. Let's open an issue in upjet to track this.
| @@ -1,6 +1,6 @@ | |||
| name: Bug Report | |||
| description: Help us diagnose and fix bugs in Official GCP Provider | |||
| labels: bug,needs:triage | |||
| labels: bug | |||
There was a problem hiding this comment.
Why do we no longer label new bugs or issues with needs:triage anymore?
There was a problem hiding this comment.
We removed these labels in the upjet move PR: crossplane/upjet#279. I used this PR as source for these updates.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR applies license changes.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested