Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
follow up for
#238
and revert from
#244
the page_title is different for provider-vault then to other providers
page_title: "Vault: vault_ad_secret_backend_library resource"
for that reason i added a small code path to make the example generation working
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
rerun make generate in upbound official-providers for aws, gcp and azure
crossplane-contrib/provider-upjet-aws#806 (we have a small diff in
config/provider-metadata.yaml
because some markdown pages using ' instead of " and the new version fixed this)crossplane-contrib/provider-upjet-gcp#347
crossplane-contrib/provider-upjet-azure#502
crossplane-contrib/provider-pagerduty#18 (we have a small diff in
config/provider-metadata.yaml
because some markdown pages using ' instead of " and the new version fixed this)https://github.com/upbound/provider-vault/pull/7/files
here we see that all examples now generated: