Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(doc-generator): fix generation examples for provider-vault" #244

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Aug 1, 2023

Reverts #238

Turns out that the generators for the AWS provider:

❯ git status apis
On branch bump-upjet
Your branch is up to date with 'origin/bump-upjet'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   apis/lightsail/v1beta1/zz_bucket_types.go

no changes added to commit (use "git add" and/or "git commit -a")

For provider-gcp:

❯ git status apis
On branch bump-upjet
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   apis/cloudplatform/v1beta1/zz_serviceaccount_types.go
        modified:   apis/cloudplatform/v1beta1/zz_serviceaccountkey_types.go
        modified:   apis/kms/v1beta1/zz_keyring_types.go
        modified:   apis/kms/v1beta1/zz_keyringimportjob_types.go

no changes added to commit (use "git add" and/or "git commit -a")

I did not check provider-{azure,azuread}.

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 2ef67f5 into main Aug 1, 2023
4 checks passed
@ulucinar ulucinar deleted the revert-238-fix/doc-generator branch August 1, 2023 14:10
@haarchri haarchri mentioned this pull request Aug 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants