Update new provider documentation #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muvaffak Onus <[email protected]>
2 tasks
Signed-off-by: Muvaffak Onus <[email protected]>
muvaf
force-pushed
the
upd-new-provider
branch
from
e11c681
to
785f496
Compare
muvaf
force-pushed
the
upd-new-provider
branch
from
083771d
to
ca4949a
Compare
Signed-off-by: Muvaffak Onus <[email protected]>
muvaf
force-pushed
the
upd-new-provider
branch
from
ca4949a
to
2a20f45
Compare
muvaf
commented
Oct 20, 2022
ulucinar
approved these changes
Oct 20, 2022
| ) | ||
|
|
||
| func GetProvider() *tjconfig.Provider { | ||
| ... | ||
| for _, configure := range []func(provider *tjconfig.Provider){ | ||
| // add custom config functions | ||
| - null.Configure, |
There was a problem hiding this comment.
nit: Why do we have the literal null here?
There was a problem hiding this comment.
It's because the provider name is null, i.e. hashicorp/null.
| // This resource need the repository in which branch would be created | ||
| // as an input. And by defining it as a reference to Repository | ||
| // object, we can build cross resource referencing. See | ||
| // repositoryRef in the example in the Testing section below. | ||
| r.References["repository"] = config.Reference{ | ||
| Type: "github.com/crossplane-contrib/provider-jet-github/apis/repository/v1alpha1.Repository", | ||
| Type: "github.com/myorg/provider-github/apis/repository/v1alpha1.Repository", |
There was a problem hiding this comment.
Looking at the examples below, should myorg be upbound or vice versa?
There was a problem hiding this comment.
It should be myorg everywhere in the user's provider since they'll need to use their own organization. Is there an inconsistency you caught?
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates to work with Upjet.
Fixes #114
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Together with crossplane/upjet-provider-template#7 and confirmed that I see repo and branch.