Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is generating-a-provider doc up do date? #114

Closed
IvanTurgenev1 opened this issue Oct 19, 2022 · 3 comments · Fixed by #115
Closed

Is generating-a-provider doc up do date? #114

IvanTurgenev1 opened this issue Oct 19, 2022 · 3 comments · Fixed by #115
Labels
enhancement New feature or request

Comments

@IvanTurgenev1
Copy link

What problem are you facing?

The example has the following block of code :

pc := tjconfig.NewProviderWithSchema([]byte(providerSchema), resourcePrefix, modulePath,
    tjconfig.WithIncludeList([]string{
        "github_repository$",
        "github_branch$",
    }))

but in upjet template this code looks really different

	pc := tjconfig.NewProvider([]byte(providerSchema), resourcePrefix, modulePath, nil,
		tjconfig.WithIncludeList(ExternalNameConfigured()),
		tjconfig.WithDefaultResourceOptions(
			ExternalNameConfigurations(),
		))

is this doc need to be updated? or i did smth wrong?

@IvanTurgenev1 IvanTurgenev1 added the enhancement New feature or request label Oct 19, 2022
@IvanTurgenev1
Copy link
Author

Looks like doc is outdated:
Problems arise when generating a provider.
after using hack.sh I get access errors to repositories, cause they are simple doesn't exist ><

github.com/upbound/provider-salt/cmd/provider imports
github.com/upbound/upjet-provider-salt/apis/v1alpha1: cannot find module providing package github.com/upbound/upjet-provider-salt/apis/v1alpha1: module github.com/upbound/upjet-provider-salt/ apis/v1alpha1: git ls-remote -q origin in /Users/ivan.turgenev/git/upjet-provider-salt/.work/pkg/pkg/mod/cache/vcs/baf673e8d21bf52024ae6fc58c550a41252213a41280b819a69d967976c582: exit
ERROR: Repository not found.

@muvaf
Copy link
Member

muvaf commented Oct 20, 2022

Thanks for opening this issue @IvanTurgenev1 ! Yes, it seems it's outdated. I'll work on updating it and get back to you.

@muvaf
Copy link
Member

muvaf commented Oct 20, 2022

@IvanTurgenev1 The PR #115 contains most up-to-date information including the TF provider documentation parsing for CRD API references!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants