Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct node pool external names #454

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apis/container/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions apis/container/v1beta1/zz_nodepool_types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions apis/containeraws/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions apis/containeraws/v1beta1/zz_nodepool_types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions apis/containerazure/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions apis/containerazure/v1beta1/zz_nodepool_types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions config/externalname.go
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ var noForkExternalNameConfigs = map[string]config.ExternalName{
//
// Imported by using the following format: projects/my-gcp-project/locations/us-east1-a/clusters/my-cluster
"google_container_cluster": config.TemplatedStringAsIdentifier("name", "projects/{{ .setup.configuration.project }}/locations/{{ .parameters.location }}/clusters/{{ .external_name }}"),
// Imported by using the following format: my-gcp-project/us-east1-a/my-cluster/main-pool
"google_container_node_pool": config.TemplatedStringAsIdentifier("name", "{{ .setup.configuration.project }}/{{ .parameters.location }}/{{ .parameters.cluster }}/{{ .external_name }}"),
// Imported by using the following format: projects/my-gcp-project/locations/us-east1-a/clusters/my-cluster/nodePools/main-pool
"google_container_node_pool": config.TemplatedStringAsIdentifier("name", "{{ .parameters.cluster }}/nodePools/{{ .external_name }}"),

// containeranalysis
//
Expand All @@ -332,15 +332,15 @@ var noForkExternalNameConfigs = map[string]config.ExternalName{
//
// Imported by using the following format: projects/my-gcp-project/locations/us-east1-a/clusters/my-cluster
"google_container_aws_cluster": config.TemplatedStringAsIdentifier("name", "projects/{{ .setup.configuration.project }}/locations/{{ .parameters.location }}/clusters/{{ .external_name }}"),
// Imported by using the following format: my-gcp-project/us-east1-a/my-cluster/main-pool
"google_container_aws_node_pool": config.TemplatedStringAsIdentifier("name", "{{ .setup.configuration.project }}/{{ .parameters.location }}/{{ .parameters.cluster }}/{{ .external_name }}"),
// Imported by using the following format: projects/my-gcp-project/locations/us-east1-a/clusters/my-cluster/nodePools/main-pool
"google_container_aws_node_pool": config.TemplatedStringAsIdentifier("name", "{{ .parameters.cluster }}/nodePools/{{ .external_name }}"),

// containerazure
//
// Imported by using the following format: projects/my-gcp-project/locations/us-east1-a/clusters/my-cluster
"google_container_azure_cluster": config.TemplatedStringAsIdentifier("name", "projects/{{ .setup.configuration.project }}/locations/{{ .parameters.location }}/clusters/{{ .external_name }}"),
// Imported by using the following format: my-gcp-project/us-east1-a/my-cluster/main-pool
"google_container_azure_node_pool": config.TemplatedStringAsIdentifier("name", "{{ .setup.configuration.project }}/{{ .parameters.location }}/{{ .parameters.cluster }}/{{ .external_name }}"),
// Imported by using the following format: projects/my-gcp-project/locations/us-east1-a/clusters/my-cluster/nodePools/main-pool
"google_container_azure_node_pool": config.TemplatedStringAsIdentifier("name", "{{ .parameters.cluster }}/nodePools/{{ .external_name }}"),
// Imported by using the following format: projects/my-gcp-project/locations/us-east1-a/azureClients/my-client
"google_container_azure_client": config.TemplatedStringAsIdentifier("name", "projects/{{ .setup.configuration.project }}/locations/{{ .parameters.location }}/azureClients/{{ .external_name }}"),

Expand Down
3 changes: 3 additions & 0 deletions package/crds/container.gcp.upbound.io_nodepools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,9 @@ spec:
need this value, don't set it. If you do need it, you can use a lifecycle block to
ignore subsequent changes to this field.
type: number
location:
description: The location (region or zone) of the cluster.
type: string
management:
description: |-
Node management configuration, wherein auto-repair and
Expand Down
9 changes: 7 additions & 2 deletions package/crds/containeraws.gcp.upbound.io_nodepools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,6 @@ spec:
1.19.10-gke.1000). You can list all supported versions on a
given Google Cloud region by calling GetAwsServerConfig.
type: string
required:
- location
type: object
initProvider:
description: |-
Expand Down Expand Up @@ -549,6 +547,9 @@ spec:
type: array
type: object
type: array
location:
description: The location for the resource
type: string
maxPodsConstraint:
description: The constraint on the maximum number of pods that
can be run simultaneously on a node in the node pool.
Expand Down Expand Up @@ -748,6 +749,10 @@ spec:
rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies
|| ''Update'' in self.managementPolicies) || has(self.forProvider.config)
|| (has(self.initProvider) && has(self.initProvider.config))'
- message: spec.forProvider.location is a required parameter
rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies
|| ''Update'' in self.managementPolicies) || has(self.forProvider.location)
|| (has(self.initProvider) && has(self.initProvider.location))'
- message: spec.forProvider.maxPodsConstraint is a required parameter
rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies
|| ''Update'' in self.managementPolicies) || has(self.forProvider.maxPodsConstraint)
Expand Down
9 changes: 7 additions & 2 deletions package/crds/containerazure.gcp.upbound.io_nodepools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,6 @@ spec:
description: The Kubernetes version (e.g. 1.19.10-gke.1000) running
on this node pool.
type: string
required:
- location
type: object
initProvider:
description: |-
Expand Down Expand Up @@ -378,6 +376,9 @@ spec:
type: string
type: object
type: array
location:
description: The location for the resource
type: string
maxPodsConstraint:
description: The constraint on the maximum number of pods that
can be run simultaneously on a node in the node pool.
Expand Down Expand Up @@ -578,6 +579,10 @@ spec:
rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies
|| ''Update'' in self.managementPolicies) || has(self.forProvider.config)
|| (has(self.initProvider) && has(self.initProvider.config))'
- message: spec.forProvider.location is a required parameter
rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies
|| ''Update'' in self.managementPolicies) || has(self.forProvider.location)
|| (has(self.initProvider) && has(self.initProvider.location))'
- message: spec.forProvider.maxPodsConstraint is a required parameter
rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies
|| ''Update'' in self.managementPolicies) || has(self.forProvider.maxPodsConstraint)
Expand Down
Loading