Correct node pool external names #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Oddy <[email protected]>
JonathanO
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
|
Signed-off-by: Jonathan Oddy <[email protected]>
JonathanO
force-pushed
the
correct_node_pool_external_names
branch
from
bc6b31d
to
32e5411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
container NodePool identifiers are in the form
projects/my-gcp-project/locations/us-east1-a/clusters/my-cluster/nodePools/main-pool, however the ID of the cluster already contains the project and location parts of the path.This will still generate incorrect IDs if the user supplies just the cluster name (without path) + location + project explicitly, however the pattern in other PRs is to assume that resources like cluster are passed with the path (as they will be if provided via the resolver.)
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Ran in kind.