Add Support for Observe Only Resources

[ulucinar]

Description of your changes

This PR adds support for Observe Only resources. It also bumps up to v0.16.1.
Related PR: crossplane-contrib/provider-upjet-aws#672

I have:

• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Provisioned and orphaned a network.VirtualNetwork resource. Then I tried importing it while running the provider with the newly introduced alpha feature disabled. As expected, I observed the managementPolicy is set to a non-default value but the feature is not enabled Synced == false status condition. Then, I enabled the new alpha feature by passing --enable-management-policies command-line option to the provider and successfully imported the managed resource using the following manifest:

apiVersion: network.azure.upbound.io/v1beta1
kind: VirtualNetwork
metadata:
  annotations:
    crossplane.io/external-name: example
  name: example-import
spec:
  managementPolicy: ObserveOnly
  forProvider:
    resourceGroupName: example-virtualnetwork

The full manifest of the imported resource (spec.managementPolicy: ObserveOnly) looks like the following:

apiVersion: network.azure.upbound.io/v1beta1
kind: VirtualNetwork
metadata:
  annotations:
    crossplane.io/external-name: example
  creationTimestamp: "2023-04-18T13:22:00Z"
  generation: 1
  name: example-import
  resourceVersion: "92235"
  uid: 77e3f3ef-1540-4240-adc2-facc300240ca
spec:
  deletionPolicy: Delete
  forProvider:
    resourceGroupName: example-virtualnetwork
  managementPolicy: ObserveOnly
  providerConfigRef:
    name: default
status:
  atProvider:
    addressSpace:
    - 10.0.0.0/16
    bgpCommunity: ""
    edgeZone: ""
    flowTimeoutInMinutes: 0
    guid: 96cbba00-bd68-4375-8d3a-68978ac79099
    id: /subscriptions/.../resourceGroups/example-virtualnetwork/providers/Microsoft.Network/virtualNetworks/example
    location: westeurope
    resourceGroupName: example-virtualnetwork
  conditions:
  - lastTransitionTime: "2023-04-18T13:22:08Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-04-18T13:22:08Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced

Update and performance regression tests have been done in the context of crossplane-contrib/provider-upjet-aws#672.

[ulucinar]

/test-examples="examples/network/virtualnetwork.yaml"

[turkenf]

We can ignore check-examples job failure. The related issue about this: #433

[turkenh]

Thank you @ulucinar 🙏

[turkenh]

Hmm, should this be an identifier field 🤔
Could a resource group be observed without location?

[ulucinar]

This resource's external-name configuration is as follows:

config.TemplatedStringAsIdentifier("name", "/subscriptions/{{ .setup.configuration.subscription_id }}/resourceGroups/{{ .external_name }}"),

, which does not refer to the location argument. I think this explains why it's not treated as an identifier argument.

I've also verified that using the following manifest, we can import an existing Azure resource group:

apiVersion: azure.upbound.io/v1beta1
kind: ResourceGroup
metadata:
  annotations:
    crossplane.io/external-name: example-resources
  name: example-import
spec:
  managementPolicy: ObserveOnly
  forProvider: {}

The imported resource's manifest is:

apiVersion: azure.upbound.io/v1beta1
kind: ResourceGroup
metadata:
  annotations:
    crossplane.io/external-name: example-resources
  creationTimestamp: "2023-04-18T17:12:21Z"
  generation: 1
  name: example-import
  resourceVersion: "122209"
  uid: e59544e2-04ca-49d7-92c3-47b73b339ecc
spec:
  deletionPolicy: Delete
  forProvider: {}
  managementPolicy: ObserveOnly
  providerConfigRef:
    name: default
status:
  atProvider:
    id: /subscriptions/.../resourceGroups/example-resources
    location: westeurope
    tags:
      provisioner: crossplane
  conditions:
  - lastTransitionTime: "2023-04-18T17:12:29Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-04-18T17:12:29Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced

Looks like we are fine.