-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Observe Only Resources #672
Conversation
162cc26
to
ea26e34
Compare
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Locally rebased this PR so that |
// region as a parameter for all resources to be consistent with | ||
// the native aws provider, and now, we need to add manually it to | ||
// the identifier fields for all resources. | ||
r.ExternalName.IdentifierFields = append(r.ExternalName.IdentifierFields, "region") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that we do not need to treat the iam
group specially because although spec.forProvider.region
is declared as an identifier field because that field is missing for the managed resources in that group, it becomes ineffective.
I did some performance tests by building an image from this branch. Any performance regression was not observed in these tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenh, lgtm.
Description of your changes
This PR adds support for Observe Only resources.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Basic Observe Scenario
I have created an Observe Only RDS instance as follows:
And verified that the resource was ready&synced and all the fields at
status.atProvider
were appropriately filled.Upgrade Path
Ready
&Synced
.Installed
&Healthy
.Ready
&Synced
.Ready
&Synced
and provider runs properly with the alpha feature enabled.Ready
&Synced
with all observed fields filled appropriately.