Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qemu to 8.2.0 for CVTPS2PD fix #78

Closed
kasper93 opened this issue Jan 4, 2024 · 1 comment
Closed

Update qemu to 8.2.0 for CVTPS2PD fix #78

kasper93 opened this issue Jan 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kasper93
Copy link

kasper93 commented Jan 4, 2024

We use QEMU emulation for stability, because xhyve hypervisor was failing half of the time last time we tried it. I've seen in recent release notes that there seems to be mitigation in place, so we might revisit that, but that's for another day.

For now I would like to request QEMU update to latest stable (8.2.0) as recently we hit the code which crashes QEMU. We get SIGBUS on valid code, see https://github.com/mpv-player/mpv/actions/runs/7377653152/job/20071858642

After painful debugging, because I couldn't reproduce locally, it seems to be CVTPS2PD instruction that fails. And sure enough after quick search the issue we see likely has been fixed in the recent stable release of QEMU (8.2.0)
Issue: https://gitlab.com/qemu-project/qemu/-/issues/1377
Fix: https://gitlab.com/qemu-project/qemu/-/commit/abd41884c530aa025ada253bf1a5bd0c2b808219

Thanks

@kasper93 kasper93 changed the title Update qemu t 8.2.0 for CVTPS2PD fix Update qemu to 8.2.0 for CVTPS2PD fix Jan 4, 2024
kasper93 added a commit to kasper93/mpv that referenced this issue Jan 4, 2024
This is workaround to not emit instructions that are broken with current
version of QEMU used in CI job.

Fixes SIGBUS on valid code when executed in QEMU caused by issue with
CVTPS2PD instruction.

QEMU issue:
https://gitlab.com/qemu-project/qemu/-/issues/1377

QEMU fix:
https://gitlab.com/qemu-project/qemu/-/commit/abd41884c530aa025ada253bf1a5bd0c2b808219

Should be resolved after QEMU update to 8.2.0:
cross-platform-actions/action#78
@jacob-carlborg jacob-carlborg added the enhancement New feature or request label Jan 4, 2024
@jacob-carlborg
Copy link
Contributor

Yes. We tried to update to QEMU 8.1, but that broke OpenBSD. Hopefully 8.2 works better.

sfan5 pushed a commit to mpv-player/mpv that referenced this issue Jan 4, 2024
This is workaround to not emit instructions that are broken with current
version of QEMU used in CI job.

Fixes SIGBUS on valid code when executed in QEMU caused by issue with
CVTPS2PD instruction.

QEMU issue:
https://gitlab.com/qemu-project/qemu/-/issues/1377

QEMU fix:
https://gitlab.com/qemu-project/qemu/-/commit/abd41884c530aa025ada253bf1a5bd0c2b808219

Should be resolved after QEMU update to 8.2.0:
cross-platform-actions/action#78
xrun1 pushed a commit to xrun1/mpv-svp-fix that referenced this issue Mar 12, 2024
This is workaround to not emit instructions that are broken with current
version of QEMU used in CI job.

Fixes SIGBUS on valid code when executed in QEMU caused by issue with
CVTPS2PD instruction.

QEMU issue:
https://gitlab.com/qemu-project/qemu/-/issues/1377

QEMU fix:
https://gitlab.com/qemu-project/qemu/-/commit/abd41884c530aa025ada253bf1a5bd0c2b808219

Should be resolved after QEMU update to 8.2.0:
cross-platform-actions/action#78
korli added a commit to korli/action that referenced this issue Mar 15, 2024
Release 0.23.0

Added:
- Add support for FreeBSD 14.0 ([cross-platform-actions#74](cross-platform-actions#74))
- Add post run step that prints the VM output
- Support hardware accelerated virtualization on Linux runners ([cross-platform-actions#47](cross-platform-actions#47))

Fixed:
- OpenBSD VM fails during "Initializing VM" with QEMU on macOS ([cross-platform-actions#73](cross-platform-actions#73))
- Use same options for rsync in both directions ([cross-platform-actions#76](cross-platform-actions#76))

Changed:
- Update qemu to 8.2.0 for CVTPS2PD fix ([cross-platform-actions#78](cross-platform-actions#78))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants