-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync back files from VM skips all symlinks #76
Comments
This is an oversight. Perhaps it would make sense to use the same set of flags to sync in both directions. |
Hi @jacob-carlborg, Can I be of help by providing a PR that makes it use the same flags on both directions? It would really help us out of this rsync symlink issue would be fixed. |
@mhuijgen sure, I've completely forgotten about this. |
Created a PR #81 |
Release 0.23.0 Added: - Add support for FreeBSD 14.0 ([cross-platform-actions#74](cross-platform-actions#74)) - Add post run step that prints the VM output - Support hardware accelerated virtualization on Linux runners ([cross-platform-actions#47](cross-platform-actions#47)) Fixed: - OpenBSD VM fails during "Initializing VM" with QEMU on macOS ([cross-platform-actions#73](cross-platform-actions#73)) - Use same options for rsync in both directions ([cross-platform-actions#76](cross-platform-actions#76)) Changed: - Update qemu to 8.2.0 for CVTPS2PD fix ([cross-platform-actions#78](cross-platform-actions#78))
It looks like rsync is ignoring symlinks during sync back.
Is this intentional or oversight?
If the latter, would it be possible to add -l to the rsync command used:
--links, -l copy symlinks as symlinks
Looking at the rsync flags used to sync to the VM they are covered by the -a option
/usr/bin/rsync -auzrtopg ......
Using -a could be an option as well, but this also includes special device files (-D option) as well as symlinks.
If you want to keep using -a, I think its safe to remove rtopg options, since they are part of the -a option.
The text was updated successfully, but these errors were encountered: