Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes refacto bug on n-hours intervals #355

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fixes refacto bug on n-hours intervals #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion timeseries/src/main/scala/com/criteo/cuttle/timeseries/TimeSeriesScheduler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ object TimeSeriesCalendar {

private[timeseries] object TimeSeriesCalendarView {
def apply(calendar: TimeSeriesCalendar) = calendar match {
case TimeSeriesCalendar.NHourly(h) => new NHourlyView(h, 1)
case TimeSeriesCalendar.NHourly(h) => new NHourlyView(1, h)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange that you're not passing timezone here.
I highly doubt that anybody is using anything different from UTC, but just in case, maybe we could add it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, for Hourly it does not matter, for NHourly it does :) Will do that in another review.

case TimeSeriesCalendar.Daily(tz) => new DailyView(tz, 1)
case TimeSeriesCalendar.Weekly(tz, firstDay) => new WeeklyView(tz, firstDay, 1)
case TimeSeriesCalendar.Monthly(tz) => new MonthlyView(tz, 1)
Expand Down