Fixes refacto bug on n-hours intervals #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of hours and aggregationfactor were swapped.
guillaumebort
approved these changes
Jan 30, 2019
alexeyeryshev
previously requested changes
Jan 30, 2019
| @@ -150,7 +150,7 @@ object TimeSeriesCalendar { | |||
|
|
|||
| private[timeseries] object TimeSeriesCalendarView { | |||
| def apply(calendar: TimeSeriesCalendar) = calendar match { | |||
| case TimeSeriesCalendar.NHourly(h) => new NHourlyView(h, 1) | |||
| case TimeSeriesCalendar.NHourly(h) => new NHourlyView(1, h) | |||
There was a problem hiding this comment.
It seems strange that you're not passing timezone here.
I highly doubt that anybody is using anything different from UTC, but just in case, maybe we could add it?
There was a problem hiding this comment.
You are right, for Hourly it does not matter, for NHourly it does :) Will do that in another review.
dufrannea
dismissed
alexeyeryshev’s stale review
Will merge & perform changes in another review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of hours and aggregationfactor were swapped. This led to a display error where cells width was not respected in the calendar view.