Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: detailed configuration for order book responses #341 #50

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

kingcre
Copy link
Contributor

@kingcre kingcre commented Jul 26, 2022

Description

Tasks

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@kingcre kingcre requested review from crypin and queencre as code owners July 26, 2022 08:17
@kingcre kingcre self-assigned this Jul 26, 2022
@crypin
Copy link
Member

crypin commented Jul 27, 2022

Could you add changelog?

@crypin crypin merged commit 430c148 into main Jul 27, 2022
@kingcre kingcre deleted the cherry-pick/341 branch August 1, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants