Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: detailed configuration for order book responses #341

Merged
merged 2 commits into from
Jul 27, 2022
Merged

refactor!: detailed configuration for order book responses #341

merged 2 commits into from
Jul 27, 2022

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Jul 26, 2022 •
edited
Loading

Description

Make MakeOrderBookPairResponse to accept OrderBookConfig which is used to configure the order book responses.
It consists of two fields, PriceUnitPower and MaxNumTicks.

Tasks

  • Refactor MakeOrderBookPairResponse

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang self-assigned this Jul 26, 2022
@hallazzang hallazzang marked this pull request as ready for review July 26, 2022 08:15
@kingcre kingcre mentioned this pull request Jul 26, 2022
Merged
10 tasks
dongsam
dongsam reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Could you add CHANGELOG for v2.1.1?

@dongsam dongsam self-requested a review July 26, 2022 12:19
@dongsam dongsam added this to the v2.1.x milestone Jul 27, 2022
@hallazzang hallazzang merged commit 197de6e into main Jul 27, 2022
@dongsam dongsam removed the c-sync label Jul 27, 2022
dongsam pushed a commit that referenced this pull request Aug 31, 2022
@crypin
Merge pull request #50 from crescent-network/cherry-pick/341
430c148 
refactor!: detailed configuration for order book responses #341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaybxyz jaybxyz jaybxyz approved these changes

@dongsam dongsam dongsam approved these changes

Assignees

@hallazzang hallazzang

Labels
x/liquidity
Projects
None yet
Milestone
v2.1.x
Development

Successfully merging this pull request may close these issues.
3 participants
@hallazzang @dongsam @jaybxyz