Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary Report fixes #158

Merged
merged 30 commits into from
Oct 29, 2024
Merged

Preliminary Report fixes #158

merged 30 commits into from
Oct 29, 2024

Conversation

Krishnakumarskr
Copy link
Member

Krishnakumarskr and others added 10 commits October 23, 2024 21:42
jplodge-pro and others added 12 commits October 28, 2024 16:02
@jplodge-pro
Tweaked to allow setting of a custom maxDeposit while also accessin…
769fee7 
…g the default functionality.
@jplodge-pro
Added the Branch Coverage option to the genhtml invocation.
ef8d68b
@jplodge-pro
Added a test case for Max Deposit being exceeded on deposit.
8288924 
Corrected the typo in all test names
@Krishnakumarskr
pulled latest changes
065ac0b
@Krishnakumarskr
Merge branch 'preliminary-report-fixes' of https://github.com/credbul…
48ec6c2 
…l/credbull-defi into preliminary-report-fixes
@Krishnakumarskr
added test cases
9339f84
@nawar-hisso
🔀 Merge
323511c
@nawar-hisso
🔥 Remove Unused Code
0341366
@nawar-hisso
Merge pull request #165 from credbull/optimize-multi-token-vault-test…
aa503e5 
…-coverage

Add Test Cases For MultiTokenVault
@Krishnakumarskr
test case for fractional redeem
4ad6226
@Krishnakumarskr
reverted fix for fractional shares and added tests
c616d7d
@Krishnakumarskr
Merge branch 'preliminary-report-fixes' of https://github.com/credbul…
a65e1e2 
…l/credbull-defi into preliminary-report-fixes
lucasia
lucasia reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@lucasia lucasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see draft comments

lucasia and others added 5 commits October 28, 2024 17:07
@lucasia
fix: Reduce LiquidStones minimum threshold for shares to assets conve…
0d24bb0 
…rsion (and vice-versa)
@lucasia
chore: Fix minor linting issue
ca9348c
@lucasia
chore: Add test for Deposit and Redeem at cut-off times
0258628
@lucasia
fix: Correct LiquidStone product to return 0 returns when depositing …
c782b73 
…and requesting redeem the same day
@ChaiSomsri96 @lucasia
F-2024-6700 - TimelockAsyncUnlock (#164)
cce3896 
* feat: update _unlock internal function

* feat: update

* feat: upate test scenarios

* feat: update comment

* fix: Move cancelUnlock to Timelock.  Changed to use owner.

---------

Co-authored-by: Ian Lucas <[email protected]>
@lucasia lucasia marked this pull request as ready for review October 29, 2024 13:52
lucasia
lucasia approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@lucasia lucasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work team, approved. will merge shortly after builds.

@lucasia lucasia merged commit 5581781 into dev/liquid-audit-fixes Oct 29, 2024
4 of 6 checks passed
@lucasia lucasia deleted the preliminary-report-fixes branch October 29, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasia lucasia lucasia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Krishnakumarskr @lucasia @nawar-hisso @jplodge-pro @ChaiSomsri96