Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiquidContinuousMultiTokenVault inconsistent application of accounts (msgSender, owner, receiver, controller) #162

Closed
4 tasks done
lucasia opened this issue Oct 24, 2024 · 0 comments
Closed
4 tasks done

LiquidContinuousMultiTokenVault inconsistent application of accounts (msgSender, owner, receiver, controller) #162

lucasia opened this issue Oct 24, 2024 · 0 comments
Assignees
@lucasia
Labels
bug Something isn't working
Milestone
LiquidStone Produ...

Comments

@lucasia
Copy link
Member

lucasia commented Oct 24, 2024 •
edited
Loading

Rationalize our use of the accounts. We use msgSender and owner interchangeably (sometimes). We completely ignore controller (sometimes).

https://github.com/credbull/credbull-defi/blob/a3316f36c4d54f48cb222a4d6b59fb014524b6ee/packages/contracts/src/yield/LiquidContinuousMultiTokenVault.sol#L209C1-L252C6

Review all of the following:

  • requestDeposit
  • deposit
  • requestRedeem
  • redeem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasia lucasia

Labels
bug Something isn't working
Projects
None yet
Milestone
LiquidStone Product Launch
Development

No branches or pull requests
1 participant
@lucasia