Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: Fix package installation woes with setuptools/backports.tarfile, and PyInstaller #201

Merged
merged 2 commits into from
Jul 18, 2024
+15 −4
Merged

Setup: Fix package installation woes with setuptools/backports.tarfile, and PyInstaller #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
923073b
Setup: Fix `ImportError: cannot import name 'tarfile' from 'backports'`
amotl Jul 17, 2024
a4ba5e8
Setup: Fix PyInstaller's `Failed to import module`
amotl Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,14 @@ jobs:
- name: Set up project
run: |

# `setuptools 0.64.0` adds support for editable install hooks (PEP 660).
# `setuptools 64` adds support for editable install hooks (PEP 660).
# https://github.com/pypa/setuptools/blob/main/CHANGES.rst#v6400
pip install "setuptools>=64" --upgrade
# `setuptools 71` significantly re-vendors setuptools packages, causing hiccups on Python 3.8.
# https://github.com/pypa/setuptools/pull/4457
pip install "setuptools>=64,<71" --upgrade

# Install package in editable mode.
pip install --use-pep517 --prefer-binary --editable=.[full,test,develop]
pip install --use-pep517 --prefer-binary --editable='.[full,test,develop]'

- name: Run linter and software tests
env:
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/release-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,16 @@ jobs:
cache-dependency-path: 'pyproject.toml'

- name: Set up project
run: pip install --use-pep517 --prefer-binary --editable='.[cfr,release-cfr]'
run: |

# `setuptools 64` adds support for editable install hooks (PEP 660).
# https://github.com/pypa/setuptools/blob/main/CHANGES.rst#v6400
# `setuptools 71` significantly re-vendors setuptools packages, causing hiccups on Python 3.8.
# https://github.com/pypa/setuptools/pull/4457
pip install "setuptools>=64,<71" --upgrade

# Install package in editable mode.
pip install --use-pep517 --prefer-binary --editable='.[cfr,release-cfr]'

- name: Build application bundle
run: poe build-cfr
Expand Down