Use DSN-style connection strings #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
changed the title
amotl
changed the title
Merged
amotl
force-pushed
the
amo/read-write-pools
branch
from
9c02151 to
082736b
Compare
amotl
force-pushed
the
amo/connectionstring-dsn
branch
from
30f8e75 to
fa255a0
Compare
amotl
force-pushed
the
amo/read-write-pools
branch
from
082736b to
b8f4119
Compare
amotl
force-pushed
the
amo/connectionstring-dsn
branch
from
fa255a0 to
a7dfd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
At #77 (comment), @hlcianfagna reported that it may not be a good idea to converge to connection strings in URL format. This patch switches over to use DSN-style connection strings.