Update to pgx4 library #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/pgx4
branch
4 times, most recently
from
681ec84 to
f7ef05c
Compare
amotl
force-pushed
the
amo/pgx4
branch
2 times, most recently
from
65a068e to
a9df2d0
Compare
Merged
hlcianfagna
reviewed
Aug 31, 2023
| // postgres://jack:[email protected]:5432/mydb?sslmode=verify-ca | ||
| connectionString := fmt.Sprintf( | ||
| "postgres://%s:%s@%s:%v/%s?connect_timeout=%v&pool_max_conns=%v", | ||
| ep.User, ep.Password, ep.Host, ep.Port, ep.Schema, ep.ConnectTimeout, ep.MaxConnections) |
There was a problem hiding this comment.
I think a password in this context may need to be URL encoded for special characters to work.
There was a problem hiding this comment.
Good point!
a) Do you suggest to encode it, or do you suggest to use the DSN notation instead?
b) FYI: In a subsequent patch, I would like to add functionality to obtain the connection string from the configuration file 1:1, and document all other options supported by pgx4 out of the box. Up until then, we need to converge it from the discrete options in one way or another.
There was a problem hiding this comment.
Hi again. Later down the line, GH-82 will start using DSN-style connection strings instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The transition from pgx3 to pgx4 introduces a few interface changes.