Merge branch 'master' into coinbase_api_revamp #19
cranktakularAnnotations
10 errors and 10 warnings
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L55
Error return value of `c.API.Endpoints.SetDefaultEndpoints` is not checked (errcheck)
|
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L6
File is not `gci`-ed with --skip-generated -s standard -s default (gci)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L1821
assignOp: replace `path = path + queryParams` with `path += queryParams` (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L1854
assignOp: replace `path = path + queryParams` with `path += queryParams` (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro_wrapper.go#L64
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro_wrapper.go#L288
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro_wrapper.go#L293
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro_wrapper.go#L307
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro_wrapper.go#L311
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro_wrapper.go#L343
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L58
exported: exported const Version3 should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L109
exported: exported type Version should have comment or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L110
exported: exported type FiatTransferType should have comment or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro_types.go#L72
exported: comment on exported type ProductBookResponse should be of the form "ProductBookResponse ..." (with optional leading article) (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L167
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro_types.go#L147
exported: exported method UnixTimestamp.UnmarshalJSON should have comment or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/ratelimit.go#L21
exported: exported const V2Rate should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro_wrapper.go#L285
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L543
exported: exported method CoinbasePro.GetUserByID should have comment or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro_types.go#L1216
exported: comment on exported type OrderbookFinalResponse should be of the form "OrderbookFinalResponse ..." (with optional leading article) (revive)
|