Merge branch 'master' into coinbase_api_revamp

.github/workflows/proto-lint.yml

@@ -23,7 +23,7 @@ jobs:
          go install google.golang.org/protobuf/cmd/protoc-gen-go
          go install google.golang.org/grpc/cmd/protoc-gen-go-grpc
 
-      - uses: bufbuild/buf-setup-action@v1.26.1
+      - uses: bufbuild/buf-setup-action@v1.28.1
 
       - name: buf generate
         working-directory: ./gctrpc

.github/workflows/tests.yml

@@ -22,7 +22,7 @@ jobs:
 
     steps:
     - name: Cancel previous workflow runs
-      uses: styfle/cancel-workflow-action@0.11.0
+      uses: styfle/cancel-workflow-action@0.12.0
       with:
         access_token: ${{ github.token }}
 
@@ -76,7 +76,7 @@ jobs:
 
     steps:
     - name: Cancel previous workflow runs
-      uses: styfle/cancel-workflow-action@0.11.0
+      uses: styfle/cancel-workflow-action@0.12.0
       with:
         access_token: ${{ github.token }}
 
@@ -125,14 +125,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Cancel previous workflow runs
-      uses: styfle/cancel-workflow-action@0.11.0
+      uses: styfle/cancel-workflow-action@0.12.0
       with:
         access_token: ${{ github.token }}
 
     - uses: actions/checkout@v4
 
     - name: Use Node.js
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: '10.8.x'
 

CONTRIBUTORS

@@ -2,8 +2,8 @@
 Thanks to the following contributors:
 thrasher- | https://github.com/thrasher-
 shazbert | https://github.com/shazbert
-gloriousCode | https://github.com/gloriousCode
 dependabot[bot] | https://github.com/apps/dependabot
+gloriousCode | https://github.com/gloriousCode
 dependabot-preview[bot] | https://github.com/apps/dependabot-preview
 xtda | https://github.com/xtda
 gbjk | https://github.com/gbjk
@@ -13,13 +13,13 @@ vazha | https://github.com/vazha
 ydm | https://github.com/ydm
 ermalguni | https://github.com/ermalguni
 MadCozBadd | https://github.com/MadCozBadd
+Beadko | https://github.com/Beadko
 vadimzhukck | https://github.com/vadimzhukck
 140am | https://github.com/140am
 marcofranssen | https://github.com/marcofranssen
 geseq | https://github.com/geseq
-Beadko | https://github.com/Beadko
-TaltaM | https://github.com/TaltaM
 samuael | https://github.com/samuael
+TaltaM | https://github.com/TaltaM
 dackroyd | https://github.com/dackroyd
 cranktakular | https://github.com/cranktakular
 khcchiu | https://github.com/khcchiu

README.md

@@ -26,7 +26,6 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Bithumb | Yes  | Yes       | NA  |
 | BitMEX | Yes | Yes | NA |
 | Bitstamp | Yes  | Yes       | No  |
-| Bittrex | Yes | Yes | NA |
 | BTCMarkets | Yes | Yes       | NA  |
 | BTSE | Yes | Yes | NA |
 | Bybit | Yes | Yes | NA |
@@ -145,25 +144,25 @@ Binaries will be published once the codebase reaches a stable condition.
 |User|Contribution Amount|
 |--|--|
 | [thrasher-](https://github.com/thrasher-) | 683 |
-| [shazbert](https://github.com/shazbert) | 301 |
-| [gloriousCode](https://github.com/gloriousCode) | 219 |
-| [dependabot[bot]](https://github.com/apps/dependabot) | 207 |
+| [shazbert](https://github.com/shazbert) | 313 |
+| [dependabot[bot]](https://github.com/apps/dependabot) | 227 |
+| [gloriousCode](https://github.com/gloriousCode) | 224 |
 | [dependabot-preview[bot]](https://github.com/apps/dependabot-preview) | 88 |
 | [xtda](https://github.com/xtda) | 47 |
-| [gbjk](https://github.com/gbjk) | 35 |
+| [gbjk](https://github.com/gbjk) | 40 |
 | [lrascao](https://github.com/lrascao) | 27 |
 | [Rots](https://github.com/Rots) | 15 |
 | [vazha](https://github.com/vazha) | 15 |
 | [ydm](https://github.com/ydm) | 15 |
 | [ermalguni](https://github.com/ermalguni) | 14 |
 | [MadCozBadd](https://github.com/MadCozBadd) | 13 |
+| [Beadko](https://github.com/Beadko) | 10 |
 | [vadimzhukck](https://github.com/vadimzhukck) | 10 |
 | [140am](https://github.com/140am) | 8 |
 | [marcofranssen](https://github.com/marcofranssen) | 8 |
 | [geseq](https://github.com/geseq) | 8 |
-| [Beadko](https://github.com/Beadko) | 6 |
+| [samuael](https://github.com/samuael) | 7 |
 | [TaltaM](https://github.com/TaltaM) | 6 |
-| [samuael](https://github.com/samuael) | 6 |
 | [dackroyd](https://github.com/dackroyd) | 5 |
 | [cranktakular](https://github.com/cranktakular) | 5 |
 | [khcchiu](https://github.com/khcchiu) | 5 |

backtester/data/kline/live/live_test.go

@@ -73,9 +73,7 @@ func TestLoadTrades(t *testing.T) {
 		ConfigFormat:  pFormat,
 	}
 	var data *gctkline.Item
-	// start is 10 mins in the past to ensure there are some trades to pull from the exchange
-	start := time.Now().Add(-time.Minute * 10)
-	data, err = LoadData(context.Background(), start, exch, common.DataTrade, interval.Duration(), cp, currency.EMPTYPAIR, a, true)
+	data, err = LoadData(context.Background(), time.Now().Add(-interval.Duration()*60), exch, common.DataTrade, interval.Duration(), cp, currency.EMPTYPAIR, a, true)
 	if err != nil {
 		t.Fatal(err)
 	}

backtester/report/report_test.go

@@ -135,11 +135,11 @@ func TestGenerateReport(t *testing.T) {
 				},
 			},
 			{
-				Exchange:  "Bittrex",
+				Exchange:  "Bitstamp",
 				Asset:     a,
 				Pair:      currency.NewPair(currency.BTC, currency.USD),
 				Interval:  gctkline.OneDay,
-				Watermark: "BITTREX - SPOT - BTC-USD - 1d",
+				Watermark: "BITSTAMP - SPOT - BTC-USD - 1d",
 				Candles: []DetailedCandle{
 					{
 						UnixMilli:      time.Date(2020, 12, 12, 0, 0, 0, 0, time.UTC).UnixMilli(),

cmd/apichecker/testupdates.json

@@ -72,17 +72,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "Bittrex",
-   "CheckType": "GitHub Sha Check",
-   "Data": {
-    "GitHubData": {
-     "Repo": "Bittrex/bittrex.github.io",
-     "Sha": "fc1ea9c10c48aa82c4dc2c6be74887ef61b5b31b"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Coinut",
    "CheckType": "GitHub Sha Check",

cmd/apichecker/updates.json

@@ -72,17 +72,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "Bittrex",
-   "CheckType": "GitHub Sha Check",
-   "Data": {
-    "GitHubData": {
-     "Repo": "Bittrex/bittrex.github.io",
-     "Sha": "fc1ea9c10c48aa82c4dc2c6be74887ef61b5b31b"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Coinut",
    "CheckType": "GitHub Sha Check",

cmd/documentation/currency_templates/fx.tmpl

@@ -7,7 +7,6 @@
 + Exchange Rates support
 + Fixer.io support
 + Open Exchange Rates support
-+ ExchangeRate.host support
 
 ### Please click GoDocs chevron above to view current GoDoc information for this package
 {{template "contributions"}}

cmd/documentation/exchanges_templates/exchanges_trade_readme.tmpl

@@ -49,7 +49,6 @@ _b in this context is an `IBotExchange` implemented struct_
 | Bithumb | Yes  | Yes       | No  |
 | BitMEX | Yes | Yes | Yes |
 | Bitstamp | Yes  | Yes       | No  |
-| Bittrex | Yes | Yes | No |
 | BTCMarkets | Yes | Yes       | No  |
 | BTSE | Yes | Yes | No |
 | Bybit | Yes | Yes | Yes |

cmd/documentation/root_templates/root_readme.tmpl

@@ -27,7 +27,6 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Bithumb | Yes  | Yes       | NA  |
 | BitMEX | Yes | Yes | NA |
 | Bitstamp | Yes  | Yes       | No  |
-| Bittrex | Yes | Yes | NA |
 | BTCMarkets | Yes | Yes       | NA  |
 | BTSE | Yes | Yes | NA |
 | Bybit | Yes | Yes | NA |

cmd/exchange_template/wrapper_file.tmpl

@@ -14,6 +14,7 @@ import (
 	"github.com/thrasher-corp/gocryptotrader/exchanges/account"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/deposit"
+	"github.com/thrasher-corp/gocryptotrader/exchanges/fundingrate"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/futures"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/order"
@@ -547,4 +548,14 @@ func ({{.Variable}} *{{.CapitalName}}) GetFuturesContractDetails(context.Context
 	return nil, common.ErrNotYetImplemented
 }
 
+// GetLatestFundingRates returns the latest funding rates data
+func ({{.Variable}} *{{.CapitalName}}) GetLatestFundingRates(_ context.Context, _ *fundingrate.LatestRateRequest) ([]fundingrate.LatestRateResponse, error) {
+	return nil, common.ErrNotYetImplemented
+}
+
+// UpdateOrderExecutionLimits updates order execution limits
+func ({{.Variable}} *{{.CapitalName}}) UpdateOrderExecutionLimits(_ context.Context, _ asset.Item) error {
+	return common.ErrNotYetImplemented
+}
+
 {{end}}

cmd/exchange_wrapper_issues/main.go

@@ -515,14 +515,14 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
 				Response:   jsonifyInterface([]interface{}{""}),
 			})
 
-			fundingRateRequest := &fundingrate.RatesRequest{
+			fundingRateRequest := &fundingrate.HistoricalRatesRequest{
 				Asset:     assetTypes[i],
 				Pair:      p,
 				StartDate: time.Now().Add(-time.Hour),
 				EndDate:   time.Now(),
 			}
-			var fundingRateResponse *fundingrate.Rates
-			fundingRateResponse, err = e.GetFundingRates(context.TODO(), fundingRateRequest)
+			var fundingRateResponse *fundingrate.HistoricalRates
+			fundingRateResponse, err = e.GetHistoricalFundingRates(context.TODO(), fundingRateRequest)
 			msg = ""
 			if err != nil {
 				msg = err.Error()