Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Bump libcramjam to 0.6.0 #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

musicinmybrain
Copy link

Just adjusting the dependency bound to build with the latest release.

@musicinmybrain musicinmybrain changed the title Bump libcramjam to 0.6.0 [DRAFT] Bump libcramjam to 0.6.0 Oct 16, 2024
@musicinmybrain
Copy link
Author

Ouch, this doesn’t work so well.

$ python3.12 -m venv _e
$ . _e/bin/activate
(_e) $ pip install -e .[dev]
(_e) $ python -m pytest
[…]
=========================================================================================== short test summary info ============================================================================================
FAILED tests/test_cli.py::test_cli_file_to_file[blosc2] - subprocess.CalledProcessError: Command '['cramjam-cli', 'blosc2', 'compress', '--input', '/tmp/tmpm210hxnm/input.txt', '--output', '/tmp/tmpm210hxnm/input.txt.blosc2']' died with <Signals.SIGSEGV: 11>.
FAILED tests/test_cli.py::test_cli_file_to_stdout[blosc2] - subprocess.CalledProcessError: Command '['cramjam-cli', 'blosc2', 'compress', '--input', '/tmp/tmpf6gb4bxs/input.txt']' died with <Signals.SIGSEGV: 11>.
======================================================================================== 2 failed, 14 passed in 41.01s =========================================================================================

@musicinmybrain
Copy link
Author

On the other hand, I now see the same thing on main, 4213e03, so it doesn’t seem to be the bump to libcramjam 0.6.0 that was responsible.

@milesgranger
Copy link
Contributor

heyya, thanks for this. It's on my radar, just need to carve out some time for it.

@musicinmybrain
Copy link
Author

I finally have all the dependencies ready to ship libcramjam 0.6.0 and python3-cramjam 2.9.0 in Fedora 41 and Rawhide.

I’m going to keep around a libcramjam0.3 compat package for now, and use it to keep cramjam-cli at 0.1.1, rather than shipping cramjam-cli 0.2.0rc2 with known segfaults. I needed that compat package in Fedora 41 to avoid breaking the shared library C ABI anyway, so this just means it will also be introduced to Fedora 42 and will hang around a bit longer than it otherwise would.

@milesgranger
Copy link
Contributor

Great to hear!
I still think about this; just started a new job a while ago and things are a bit hectic. Hoping maybe the upcoming holidays offer some time for personal projects again. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants