improve the error log message for snmp trap (influxdata#8552)

add OID value and source information into error log and make it easier for troubleshooting
craigpfeiffer · Dec 23, 2020 · 2c61fad · 2c61fad
1 parent 35a2210
commit 2c61fad
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/plugins/inputs/snmp_trap/snmp_trap.go b/plugins/inputs/snmp_trap/snmp_trap.go
@@ -284,7 +284,7 @@ func makeTrapHandler(s *SnmpTrap) handler {
 			if trapOid != "" {
 				e, err := s.lookup(trapOid)
 				if err != nil {
-					s.Log.Errorf("Error resolving V1 OID: %v", err)
+					s.Log.Errorf("Error resolving V1 OID, oid=%s, source=%s: %v", trapOid, tags["source"], err)
 					return
 				}
 				setTrapOid(tags, trapOid, e)
@@ -322,7 +322,7 @@ func makeTrapHandler(s *SnmpTrap) handler {
 				var err error
 				e, err = s.lookup(val)
 				if nil != err {
-					s.Log.Errorf("Error resolving value OID: %v", err)
+					s.Log.Errorf("Error resolving value OID, oid=%s, source=%s: %v", val, tags["source"], err)
 					return
 				}
 
@@ -340,7 +340,7 @@ func makeTrapHandler(s *SnmpTrap) handler {
 
 			e, err := s.lookup(v.Name)
 			if nil != err {
-				s.Log.Errorf("Error resolving OID: %v", err)
+				s.Log.Errorf("Error resolving OID oid=%s, source=%s: %v", v.Name, tags["source"], err)
 				return
 			}