Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the error log message for snmp trap #8552

Merged
merged 1 commit into from
Dec 23, 2020
Merged

improve the error log message for snmp trap #8552

merged 1 commit into from
Dec 23, 2020

Conversation

xiaopeng163
Copy link
Contributor

@xiaopeng163 xiaopeng163 commented Dec 12, 2020 •
edited
Loading

add OID value and source information into the error log and make it easier for troubleshooting

before:

2020-11-24T06:04:55Z E! [inputs.snmp_trap] Error resolving OID: exit status 2

after:

2020-11-24T06:04:55Z E! [inputs.snmp_trap] Error resolving OID, oid=.1.3.6.1.4.1.9.9.41, source=10.1.1.2.: exit status 2

#8535

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@xiaopeng163
improve the error log message for snmp trap
3418c63 
add OID value and source information into error log and make it easier for troubleshooting
@sjwang90 sjwang90 added area/snmp error handling Issues related to error handling labels Dec 15, 2020
srebhan
srebhan approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 16, 2020
@srebhan srebhan self-assigned this Dec 16, 2020
@sspaink sspaink merged commit 2c61fad into influxdata:master Dec 23, 2020
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
@xiaopeng163 @ssoroka
improve the error log message for snmp trap (#8552)
6fcc636 
add OID value and source information into error log and make it easier for troubleshooting

(cherry picked from commit 2c61fad)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@xiaopeng163
improve the error log message for snmp trap (influxdata#8552)
bb0ef7c 
add OID value and source information into error log and make it easier for troubleshooting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/snmp error handling Issues related to error handling ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaopeng163 @srebhan @sspaink @sjwang90