Schema.php chmod the DumpConfigFile to 0644 #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chmod the file. On some distribution, the php user write files too 'open', which generate a : `[Warning] World-writable config file 'my.cnf' is ignored` Therefore preventing the dump as it uses incorrect settings
|
This is what the defaultFileMode config setting is for. (See also defaultDirMode.) |
|
@brandonkelly I know, but And I didn't want to create a big mess by modifying a "core" function such as What should I do? Set the |
|
Sorry, I misunderstood. All clear now. |
|
Thanks for the PR! |
|
Thanks for taking the time to read it!! |
brandonkelly
added a commit
that referenced
this pull request
Apr 23, 2019
angrybrad
pushed a commit
that referenced
this pull request
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chmod the file. On some distribution, the php user write files too 'open', which generate a :
[Warning] World-writable config file 'my.cnf' is ignoredTherefore preventing the dump as it uses incorrect settings