Skip to content

Commit

Permalink
Cleanup + release note for #4163
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonkelly committed Apr 23, 2019
1 parent 7c7330d commit 891993d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-v3.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Fixed an error that occurred when an SVG with `/` characters in its `id` attributes was passed to the `svg()` Twig function. ([#4155](https://github.com/craftcms/cms/issues/4155))
- Fixed a bug where passing `:empty:` or `:notempty:` to a Matrix field param on an element query could return incorrect results for fields that had soft-deleted blocks. ([#4161](https://github.com/craftcms/cms/issues/4161))
- Fixed a bug where Craft wasn’t returning a `1` exit code for console requests if the server was running under PHP 7. ([#4153](https://github.com/craftcms/cms/issues/4153))
- Fixed a “World-writable config file 'my.cnf' is ignored” warning that could occur when creating a database backup. ([#4163](https://github.com/craftcms/cms/pull/4163))
- Fixed a bug where `craft\services\Elements::duplicateElements()` would only ignore non-safe attributes passed to the `$newAttributes` argument.
- Fixed a bug where `craft\elements\db\ElementQuery::exists()` and `offsetExists()` were ignoring cached query results.

Expand Down
8 changes: 4 additions & 4 deletions src/db/mysql/Schema.php
Original file line number Diff line number Diff line change
Expand Up @@ -323,10 +323,10 @@ private function _createDumpConfigFile(): string
}

FileHelper::writeToFile($filePath, $contents);
// Chmod the file. On some distribution, the php user write files too 'open', which generate a :
// [Warning] World-writable config file 'my.cnf' is ignored
// Therefore preventing the dump as it uses incorrect settings
chmod($filePath, 0644);

// Avoid a “world-writable config file 'my.cnf' is ignored” warning
chmod($filePath, 0644);

return $filePath;
}
}

0 comments on commit 891993d

Please sign in to comment.