-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
Pull Request Test Coverage Report for Build 2358130585Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
export type SingleOrder = RawOrder | OrderMetaData | null | ||
export type MultipleOrders = RawOrder[] | OrderMetaData[] | null | ||
export type SingleOrder = RawOrder | null | ||
export type MultipleOrders = RawOrder[] | null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both types were the same
src/api/operator/types.ts
import { OrderMetaData, TradeMetaData } from '@cowprotocol/cow-sdk'
// Raw API response
export type RawOrder = OrderMetaData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was discussed in this comment.
|
@ramirotw, @matextrem could we make a temporary definition so as not to use Or will you have the types defined in the SDK package? |
It was already exported by the sdk, so |
Summary
Remove unnecessary OrderMetaData from
cow-sdk
Fulfill with the rules alerted in SearchComponent
Comply with the rules alerted in
COW_SDK
Background