Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Release 2.8.0 #83

Merged
merged 29 commits into from
May 5, 2022
Merged

Release 2.8.0 #83

merged 29 commits into from
May 5, 2022

Conversation

henrypalacios
Copy link
Contributor

@henrypalacios henrypalacios commented May 4, 2022 •
edited
Loading

Release 2.8.0

⚠️🕵️‍♂️ DO NOT SQUASH 🕵️‍♂️ ⚠️

Main features:

  • Integration of the amazing CoW protocol SDK package cow-sdk
  • Make the Batch viewer more accessible, add button in the detail view and allow URL anchoring to tab with tx graphic.
  • Miscellaneous improvements, bug fix
    • Batch Viewer, Different trades are now shown when there is more than one interaction with the same source/target AMMs.
    • Improved UI, we have better positioned the page loaders and included an fantastic CoW custom page loader.

Changelog

Features

1c7ccea Adding class to edges with one more same direction (#84)
eb5873a Merge branch 'main' into release/2.8.0-rc.0
2f7ee66 Loading improvements (#80)
8ca4258 Adding useQuery search URL params hook (#49)
d96287f make multiple edges to target visible in the batch viewer (#78)
8725ce7 update network box label in the batch viewer (#79)
cebd490 Merge pull request #56 from cowprotocol/1066/cow-sdk-integration
91a4d81 Use SupportedChainId type from sdk
c9ee4f1 Add type to tests
6c83307 Fix property on Order type
ddf94c5 Remove unused types
4473d5f Update types on tests
b5be504 Update types and remove old tests
23c9ada Fix types for Order and Trade
b48f3f7 Update types
c93150e Update repositories URL and chat support (#53)

Dependencies Updates

8f33836 Bump to definitive version 2.8.0
7b6cfc5 Bump version to 2.8.0-rc.0
a534959 Bump cow-sdk version

matextrem and others added 26 commits March 28, 2022 14:09
@matextrem
Integrate cow sdk methods for operatorApi
29edf1b
@matextrem
Ignore ts line for not implemented methods
d2e55aa
@matextrem
One instance per network for COW SDK
b703695
@matextrem
Fix return types
f605c91
@matextrem
Merge from develop
cf28d44
@matextrem
Update deps
c02cebc
@henrypalacios
Update develop to 2.7.0 (#54)
a09da3b
@matextrem
Create object instance for cow sdk
a0acd6f
@matextrem
Update cow-sdk package
9177e2e
@matextrem
Temporary Network type
41013f8
@henrypalacios
Update repositories URL and chat support (#53)
c93150e 
* Update URLs to new repositories

* Update chat support

* Fix typo
@matextrem
Update types
b48f3f7
@matextrem
Fix types for Order and Trade
23c9ada
@matextrem
Update types and remove old tests
b5be504
@matextrem
Update types on tests
4473d5f
@matextrem
Remove unused types
ddf94c5
@matextrem
Fix property on Order type
6c83307
@matextrem
Add type to tests
c9ee4f1
@matextrem
Bump cow-sdk version
a534959
@matextrem
Use SupportedChainId type from sdk
91a4d81
@matextrem
Merge pull request #56 from cowprotocol/1066/cow-sdk-integration
cebd490 
[Explorer] Cow SDK integration
@ramirotw
update network box label in the batch viewer (#79)
8725ce7
@ramirotw
make multiple edges to target visible in the batch viewer (#78)
d96287f
@henrypalacios @alongoni
Adding useQuery search URL params hook (#49)
8ca4258 
* Adding useQuery URL's params hook

* removing button and switching to tabs

* Adding TabIcon component

* add access button to the BV (#73)

* add Link to BV

* remove underline

* remove border on BV and fix mobile view

* Fix rendering problem when changing tab

* Fix memory leak with cytoscape-popper

* Singular name suggestion, simplifying the enum

* take advantage of string enum comparison

Co-authored-by: Agustín Longoni <[email protected]>
@alongoni @ramirotw @henrypalacios
Loading improvements (#80)
2f7ee66 
* add WrapperCenter for loadings

* add cowloading svg + animations

* add ids to svg + animations

* add end of line to svg file

* fix keyframe styles

* change names and ids to camelCase

* change id to class

* move class to path instead of g tag

* remove classes and use child selectors

* remove classes from svg

* svg animations for production

* add CowLoading component on storybook

* replace Spinner -> CowLoading

* clean code

* upgrade react-inlinesvg lib

* clean CoWLoading svg

* change svg without react-inlinesvg  and fix storybook

* use react-inlinesvg

* center animation - restore spinner on tables

* fix svg classes

* remove spinner import

* delete Cow example

* center cow on BV

* Adding CowLoading on Orders tab

Co-authored-by: Ramiro Vazquez <[email protected]>
Co-authored-by: Henry Palacios <[email protected]>
@henrypalacios
Bump version to 2.8.0-rc.0
7b6cfc5
@henrypalacios henrypalacios self-assigned this May 4, 2022
@henrypalacios henrypalacios changed the base branch from develop to main May 4, 2022 22:37
@coveralls
Copy link

coveralls commented May 4, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2272671345

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 21 of 33 (63.64%) changed or added relevant lines in 17 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 44.267%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/wallet/WalletApiMock.ts 1 2 50.0%
src/const.ts 7 8 87.5%
src/services/factories/tokenList.ts 0 1 0.0%
src/state/network/hooks.ts 0 1 0.0%
src/state/network/updater.tsx 0 1 0.0%
src/utils/miscellaneous.ts 0 1 0.0%
src/utils/operator.ts 1 4 25.0%
src/utils/walletconnectOptions.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/utils/operator.ts 2 72.41%
Totals Coverage Status
Change from base Build 2109983753: 0.2%
Covered Lines: 2170
Relevant Lines: 4173
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented May 4, 2022

@elena-zh
Copy link

elena-zh commented May 5, 2022

Hey @henrypalacios , @ramirotw , great PR!
However, I think, we should include #84 PR into it (if possible).

@ramirotw ramirotw requested a review from elena-zh May 5, 2022 10:32
@elena-zh
Copy link

elena-zh commented May 5, 2022 •
edited
Loading

Hey, something wrong with SDK for Rinkeby in the PR:
image

However, seems like it was a temporary issue: now it works fine.

@ramirotw
Copy link
Contributor

ramirotw commented May 5, 2022

Hey, something wrong with SDK for Rinkeby in the PR: image

However, seems like it was a temporary issue: now it works fine.

Yes, the Barn API doesn't have a 100% uptime and sometimes you receive a 503 http error

@henrypalacios
Copy link
Contributor Author

Hey @henrypalacios , @ramirotw , great PR!
However, I think, we should include #84 PR into it (if possible).

I agree, my intention was to create an interim solution to not release with the overlapping we were getting in most cases (😅, although it grew more than planned)

alfetopito
alfetopito approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Only one small comment that does not block the release

src/services/helpers/tryGetOrderOnAllNetworks.ts Show resolved Hide resolved
@cowprotocol cowprotocol deleted a comment from github-actions bot May 5, 2022
@henrypalacios henrypalacios changed the title Release 2.8.0-RC.0 Release 2.8.0 May 5, 2022
@henrypalacios henrypalacios merged commit c28970e into main May 5, 2022
@henrypalacios henrypalacios deleted the release/2.8.0-rc.0 branch May 5, 2022 16:42
@henrypalacios henrypalacios mentioned this pull request May 6, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@alfetopito alfetopito alfetopito approved these changes

@ramirotw ramirotw Awaiting requested review from ramirotw

Assignees

@henrypalacios henrypalacios

Labels
app:Explorer Explorer App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@henrypalacios @coveralls @elena-zh @ramirotw @alfetopito @matextrem @alongoni