Improve header 2 #606
Improve header 2 #606
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
There was a problem hiding this comment.
Changes described here work as intended.
Side note, the styles seems to have changed somewhere along the way and now account balance and account address have the same background
I assume this will be changed in the follow up PRs
Also, there's no menu as of yet, so I can't change dark mode etc
|
Thanks for reviewing @alfetopito
This is correct. |
| @@ -499,7 +499,7 @@ export default function Profile() { | |||
| </FlexWrap> | |||
| </ChildWrapper> | |||
| </GridWrap> | |||
| {!account && <Web3Status openOrdersPanel={() => console.log('TODO')} />} | |||
| {!account && <Web3Status />} | |||
There was a problem hiding this comment.
be careful with this if there is async logic setting state or whatever inside Web3Status as you'll get memory leaks. Could be best to render conditoinally inside Web3Status
There was a problem hiding this comment.
When you get to review #596 please double check if this is still a concern, and whether it should be fixed.
|
I'm not sure if this is intended, or if not maybe its fixed in the following PR's but now if I'm not connected and click on the
|
Yes, good find. Definitely a bug. It happens on the latest PR as well https://pr596--cowswap.review.gnosisdev.com/#/swap?chain=gnosis_chain so will need to address it with an additional PR. |
* Rename /profile to /account * Improve header 4 (#604) * Switch to custom MenuDropdown compontent and create a POC. * Improve header 5 (#603) * Improve FAQ text * Improve header 6 (#602) * connect button styling * Further flyout menu styling * Improve header 7 (#601) * Further flyout menu styling * Uniform menu items styling * Move styled components to styled * Add hamburger icon with animation component. * Improve header 8 (#600) * Add mediaQuery hook * Improve header 9 (#599) * Progress mobile responsive menu * Progress mobile responsive menu * Improve header 10 (#598) * Move to helper function * Optimise menu code * Improve header 11 (#597) * Move URLS to an ENUM * Fix enum issue. * Styling and route fixes. * Styling. * Styling. * Header/Menu improvement (waterfall PR FINAL) (#596) * Styling. * Styling footer and bridge banner. * Improve header 13 (#610) * Fix network selector position. * Fix exports/imports for network selector. * Only open ordersPanel if account is true.
Summary
openOrdersPanelon click. Before it was only on click of the address. Now the whole pill is clickable.