Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve header 11 #597

Merged
merged 6 commits into from
Jun 2, 2022
Merged

Improve header 11 #597

merged 6 commits into from
Jun 2, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Part of a waterfall PR, the final one being Header/Menu improvement (waterfall PR FINAL)  #596
  • General styling
  • Move all routes to a single constant file routes.ts which can be referred to from anywhere in the app. Keeps a single file for defining the routes.

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@fairlighteth fairlighteth requested review from a team May 30, 2022 15:38
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

const { balance, isLoading } = useCombinedBalance()

const formattedBalance = formatSmartLocaleAware(balance, AMOUNT_PRECISION)
const formattedBalance = formatSmartLocaleAware(balance, 0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes any decimals for your displayed COW balance (to optimize for horizontal space)

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, loved the enum for path mappings

src/custom/components/Header/index.tsx Outdated Show resolved Hide resolved
src/custom/pages/App/index.tsx Outdated Show resolved Hide resolved
* Styling.

* Styling footer and bridge banner.

* Improve header 13 (#610)

* Fix network selector position.

* Fix exports/imports for network selector.

* Only open ordersPanel if account is true.
@fairlighteth fairlighteth merged commit 97c9e7c into improve-header-10 Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2022
@alfetopito alfetopito deleted the improve-header-11 branch June 3, 2022 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants