chore(release): release/1.47.0 #3104

alfetopito · 2023-09-04T10:57:46Z

Summary

Release 1.47.0

Big changes

Refactor of usd estimations ([2] feat: usd prices and amounts module #3081)

Small changes

Only update pending orders for current account (fix: update only current account pending orders #3078)

Bug fixes

Check allowance before pending tx for approval state (fix(trade): check allowance before pending tx for approval state #3090)
Add a space between "Added COW" (fix: add a space between "Added COW" #3094)
Clean form amounts after wrap/unwrap (fix(trade): clean form amounts after wrap/unwrap #3095)
Update token logo cache after tokens list loading (fix: update token logo cache after tokens list loading #3100)

Technical debt

Fix build warnings (chore(tech-debt): fix build warnings #3093)
Add bundle analyzed (feat: generate the analyze bundle for vite #3096)
Set order-book API urls from env file if present (chore: set order-book API urls from env file if present #3086)
Manual chunk management (chore(tech-debt): manually split large libs into their own chunks #3098)

Test plan

✨ NEW FEATURE ✨

Load sell and buy token USD values (SWAP/LIMIT/TWAP) * (Mainnet/Gchain/Goerli)
Load price impact (SWAP/LIMIT/TWAP) * (Mainnet/Gchain/Goerli)

Regular flow testing

Smart contract wallet (Safe):

EOA wallet (Metamask):

WalletConnect v1:

WalletConnect v2:

Account page:

Common (WalletConnect/Metamask):

…velop

* fix: update only current account pending orders * fix: don't update spot prices when window is not active

* chore: update appData module exports to fix the build warning Export AppDataUpdater of module apps/cowswap-frontend/src/modules/appData/updater/AppDataInfoUpdater.tsx was reexported through module apps/cowswap-frontend/src/modules/appData/index.ts while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order. * chore: fix useShouldZeroApprove export build warning * chore: fix build warning with multiple exports of useApproveCallback * chore: use absolute imports Co-authored-by: Alexandr Kazachenko <[email protected]> --------- Co-authored-by: Alexandr Kazachenko <[email protected]>

) * refactor: remove usd amount calc based ony CowSwap quote * refactor: move useHigherUSDValue hook to fiatAmount module * refactor: calculate priceImpact only basing on Coingecko * chore: fix import * chore: rename * chore: remove error field from price impact * chore: fix build * chore: fix build

* refactor: remove usd amount calc based ony CowSwap quote * refactor: move useHigherUSDValue hook to fiatAmount module * refactor: calculate priceImpact only basing on Coingecko * refactor: request fiat amounts only when trade is ready * refactor: deprecate parsePrice * feat: use native price api for fiat amounts * feat: module for fiat prices * chore: remove unused file * chore: simplify code * docs: fiat price module diagram * chore: fix import * chore: rename * chore: remove error field from price impact * chore: fix build * chore: fix build * fix: display price impact unknown warning only when fiat amounts are unknown * chore: rename var * chore: rename const * chore: clean up env files * chore: clean up code * chore: refactor fetchCurrencyFiatPrice * fix: fix UnknownImpactWarning displaying conditions * chore: fix naming * fix: request USDC native price on demand * fix: fix calc * fix: fix errors catching in fetchCurrencyFiatPrice * chore: additional check for zero * chore: fix comment * chore: refactor useFiatValuePriceImpact * chore: rename getCoingeckoFiatPrice * chore: rename usdc -> usd * chore: simplify useUsdPrice * chore: rename fiat -> usd * chore: rename fiat -> usd globally * chore: simplify useTradeUsdAmounts * chore: coingecko fetch rate limitter and backOff * chore: fix imports

* feat: generate the analyze bundle for vite * chore: add command analyze-bundle to root package.json --------- Co-authored-by: Alfetopito <[email protected]>

* fix(trade): clean form amounts after wrap/unwrap * chore: fix test

) * chore: manually split large libs into their own chunks * chore: remove sentry vite plugin It was meant for source maps, but when it's turned on Vercel builds always fail * chore: include elliptic into @MetaMask chunk * chore: add viem to @safe-global chunk

vercel · 2023-09-04T10:57:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
swap-dev	✅ Ready (Inspect)	Visit Preview	Sep 8, 2023 2:26pm

🌃 Cosmos ↗︎

socket-security · 2023-09-04T11:09:06Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
rollup-plugin-visualizer	5.9.2	filesystem	`+0`	537 kB	btd

anxolin · 2023-09-04T12:22:15Z

I can do "WalletConnect v2" tests

alfetopito · 2023-09-04T12:54:39Z

I'll start with new feature tests.
Would be good to someone test it too for sanity.

alfetopito · 2023-09-04T13:29:16Z

I'll start with new feature tests. Would be good to someone test it too for sanity.

| PROD | BARN | This PR |

Goerli

In this img we can see the amount of requests to the quote endpoint

Gnosis Chain

The highest deviation happened on Gnosis chain.
I assume this is due to shallow pools, as sometimes we either got a no liquidity response from the backend or high % differences.

Different pairs/amount have a more uniform amount across the versions.

Mainnet

Little deviation, mostly good

When getting throttled by coingecko, only the new PR is able to present an estimation.
The other versions hanged estimating it

When no longer throttled, we can see the values are slightly different

alfetopito · 2023-09-04T13:31:17Z

I'll start now Smart contract wallet (Safe) on gnosis chain

alfetopito · 2023-09-05T11:17:33Z

I found a few issues with Safe app on Gnosis chain #3105

Moving on to EOA wallet (Metamask)

alfetopito · 2023-09-05T13:51:27Z

Done with EOA wallet (Metamask)

Nothing new to report.

Will start with Account page

alfetopito · 2023-09-05T14:13:08Z

Done with Account page

Found one app crashing issue. Reported on Major section #3105

alfetopito · 2023-09-05T14:13:44Z

Will now test Common (WalletConnect/Metamask)

alfetopito · 2023-09-05T15:01:16Z

Done with Common (WalletConnect/Metamask) with some issues, reported on #3105

Nothing major.

Will now test WalletConnect v1

alfetopito · 2023-09-05T15:38:16Z

Done testing, nothing new

* chore: remove duplicated file * chore: work with strings for the price to avoid JS number finicky-ness * chore: do not try to calculate prices when it's < 1 USDC atom * chore: only number without integer part are too small * test: fix unit tests * feat: add new static fromNumber to FractionUtils * feat: create CurrencyAmounts from Fraction instances * chore: use Fraction rather than string or number to store prices * chore: it can be equal to 1 usdc atom * test: fix unit tests

…re is no data (#3114)

* chore: allow enough balance check to return unknown state * chore: allow undefined in the getPriceQuality fn * chore: refactor repetitive code * chore: add nit to simplify expresssion Co-authored-by: Leandro <[email protected]> * chore: move logic to private function * chore: don't allow to check quotes with same sellToken and buyToken * chore: add private function * fix: add mapping for error in the buttons map --------- Co-authored-by: Leandro <[email protected]>

* chore: uipdate query time to 30s * chore: do not clear intervals because of a change in the update function * fix: make sure we invoke the latest update function * chore: reduce the times the update function is recreated * Remove ref from dependencies Co-authored-by: Leandro <[email protected]> * chore: remove unecesary log --------- Co-authored-by: Leandro <[email protected]>

…ow the currency (#3120)

…bers left (#3121)

shoom3301 and others added 16 commits August 30, 2023 14:00

Merge branch 'main' of https://github.com/cowprotocol/cowswap into de…

dec596b

…velop

fix: update only current account pending orders (#3078)

5e2fa4c

* fix: update only current account pending orders * fix: don't update spot prices when window is not active

test: fix useTradeQuotePolling test imports (#3092)

773f0e3

fix(trade): check allowance before pending tx for approval state (#3090)

bebe49d

fix: add a space between "Added COW" (#3094)

f4f1236

feat: generate the analyze bundle for vite (#3096)

7611a3d

* feat: generate the analyze bundle for vite * chore: add command analyze-bundle to root package.json --------- Co-authored-by: Alfetopito <[email protected]>

test: e2e test fiat amount displaying (#3082)

fc9d43c

test(fiat-amount): test UsdPricesUpdater (#3091)

91bc835

chore: fix DEFAULT_USD_AMOUNT_STATE value (#3101)

e9e7c18

chore: set order-book API urls from env file if present (#3086)

bfa4433

fix(trade): clean form amounts after wrap/unwrap (#3095)

12d805c

* fix(trade): clean form amounts after wrap/unwrap * chore: fix test

fix: update token logo cache after tokens list loading (#3100)

5e2dfd1

alfetopito self-assigned this Sep 4, 2023

alfetopito added the RELEASE Included in the release that is being closed label Sep 4, 2023

vercel bot deployed to Preview September 7, 2023 09:29 View deployment

alfetopito and others added 3 commits September 7, 2023 03:52

fix(twap): load TWAP part details (#3113)

cdd3056

fix(price-impact): display unknown price impact warning only when the…

984dd66

…re is no data (#3114)

fix(swap): reset state after network changes (#3116)

6377f58

vercel bot deployed to Preview September 7, 2023 10:59 View deployment

vercel bot deployed to Preview September 7, 2023 11:09 View deployment

anxolin and others added 2 commits September 7, 2023 05:21

fix: add html space chars before banner token symbols (#3117)

f87b8d2

vercel bot deployed to Preview September 7, 2023 12:28 View deployment

fix(usd-amount): fallback to native_price API if Coingecko doesn't kn…

1fa5fb2

…ow the currency (#3120)

vercel bot deployed to Preview September 7, 2023 16:48 View deployment

fix(usd-amount): delete token from queue only if there are no subscri…

bb95c94

…bers left (#3121)

vercel bot deployed to Preview September 8, 2023 11:32 View deployment

fix: surplus modal flickering (#3124)

7d5b7ce

vercel bot deployed to Preview September 8, 2023 14:17 View deployment

fix: fix mapping network name from URL query to chainId (#3125)

a3e8bf5

vercel bot deployed to Preview September 8, 2023 14:26 View deployment

alfetopito merged commit 375cac7 into main Sep 8, 2023

alfetopito deleted the release/1.47.0 branch September 8, 2023 14:42

github-actions bot locked and limited conversation to collaborators Sep 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(release): release/1.47.0 #3104

chore(release): release/1.47.0 #3104

alfetopito commented Sep 4, 2023 •

edited

Loading

vercel bot commented Sep 4, 2023 •

edited by github-actions bot

Loading

socket-security bot commented Sep 4, 2023

anxolin commented Sep 4, 2023

alfetopito commented Sep 4, 2023

alfetopito commented Sep 4, 2023

alfetopito commented Sep 4, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

chore(release): release/1.47.0 #3104

chore(release): release/1.47.0 #3104

Conversation

alfetopito commented Sep 4, 2023 • edited Loading

Summary

Big changes

Small changes

Bug fixes

Technical debt

Test plan

✨ NEW FEATURE ✨

Regular flow testing

vercel bot commented Sep 4, 2023 • edited by github-actions bot Loading

socket-security bot commented Sep 4, 2023

anxolin commented Sep 4, 2023

alfetopito commented Sep 4, 2023

alfetopito commented Sep 4, 2023

Goerli

Gnosis Chain

Mainnet

alfetopito commented Sep 4, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 5, 2023

alfetopito commented Sep 4, 2023 •

edited

Loading

vercel bot commented Sep 4, 2023 •

edited by github-actions bot

Loading