chore(tech-debt): manually split large libs into their own chunks #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was meant for source maps, but when it's turned on Vercel builds always fail
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
requested review from
anxolin and
a team
and removed request for
anxolin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Manually split chunks into smaller chunks
Comparison:
This is an attempt to fix the Vercel build which silently fails on #3067
Now there are more chunks, and the biggest chunk is 1.7mB/585kB vs 6.7mB/1.8mB before.
With the further chunk split, the app doesn't load all at once. It might be perceived as slower to load.
Let's verify this is not causing a too big UX impact
I also removed the Sentry plugin as it was there only for uploading the generated sourcemaps. But the sourcemaps generation have been disable as that also caused the vercel build to fail...
To Test
Load comparison
Before
Screen.Recording.2023-08-31.at.17.50.49.mov
Now
Screen.Recording.2023-08-31.at.17.49.11.mov