-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permit): initial flow #3067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hack/permit # Conflicts: # src/legacy/utils/trade.ts
still untested!
* feat: add permit tag token selector * feat: add permit tag token selector * feat: optimize * Permit styles [Modal/Stepper/IconSpinner] (#3097) * feat: updates * feat: updates * feat: updates * feat: updates * feat: updates * feat: fix box shadow var * feat: optimize * feat: optimize IconSpinner (#3099) * feat: optimize IconSpinner * feat: optimize * feat: add ENUM * feat: add ENUM (#3110) * feat: updates * feat: updates * feat: updates * feat: updates * feat: updates * feat: fix box shadow var * feat: optimize * feat: optimize IconSpinner (#3099) * feat: optimize IconSpinner * feat: optimize * feat: add ENUM * feat: add ENUM * feat: add ENUM * feat: add ENUM usage * feat: add ENUM usage * feat: add ENUM usage * fix: restore yarn.lock to version matching parent branch * fix: reverted package.json changes as well * chore: restore once again yarn.lock * feat: add ENUM usage * feat: add ENUM usage --------- Co-authored-by: Alfetopito <[email protected]> * feat: updates --------- Co-authored-by: Alfetopito <[email protected]>
…#3103) * fix: trim eth-flow contract abi json file * fix(eth-flow): additionally check eth-flow order id in smart-contract * chore: remove unused ABI * chore: rename checkEthFlowOrderExists
* fix: handle individual token price query failure * chore: processQueue will no longer throw * chore: remove resetAtom as it's no longer used
alfetopito
force-pushed
the
hack/permit-3
branch
from
September 15, 2023 15:16
0807696
to
25f4053
Compare
shoom3301
reviewed
Sep 18, 2023
apps/cowswap-frontend/src/modules/appData/updater/InnerAppDataUpdater.ts
Outdated
Show resolved
Hide resolved
alfetopito
force-pushed
the
hack/permit-3
branch
from
September 19, 2023 13:36
02f85f5
to
7045e90
Compare
* chore: update the quote if appData changes * chore: refactor useEnoughBalanceAndAllowance to return balance/alloance results separately * chore: propage hasEnoughAllowance to swapFlow * refactor: rename addHooksToAppData to updateHooksOnAppData and remove hooks when unset * chore: only add hooks to order when needed, and remove when not needed * chore: show approval status now includes permittable tokens * chore: hasEnoughAllowance can be undefined * Revert "refactor: make PERMIT_GAS_LIMIT_MIN a single const rather than an obj with repeated values" This reverts commit fbddd09. * chore: reduce gas limit min for Goerli to 36k down from 55k * refactor: move default to constant * fix: rework request caching to prevent caching failed promises * chore: calculate gasLimit again using the account address * chore: hardcode gas limit to 80k
* chore: add feature flags hook useIsPermitEnabled * feat: do not query/return any result when permit is not enabled
* feat: use estimated gasLimit for quotes if higher than default * chore: add 10% to quote gas limit estimation for additional wiggle room * chore: estimate gas for real accounts also, but without extra 10% * chore: use a new empty private key for estimating the permits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial implementation of the full flow for permittable tokens
PR will merge onto https://github.com/cowprotocol/cowswap/tree/hack/permit feature branch, safe to merge.
What is included
TODOs
What is NOT included
To Test
quote
requests in the consolehooks
object withing theappData
field as part of the request