[1] fix(twap): display fallback handler banner when it's relevant #2757
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
changed the title
| const { showPriceImpactWarning } = useTwapWarningsContext() | ||
| const isFallbackHandlerRequired = useIsFallbackHandlerRequired() | ||
|
|
||
| if (showPriceImpactWarning) return isPriceImpactAccepted |
There was a problem hiding this comment.
not sure this is what you wanted to do
Didn;t you mean sth like if (showPriceImpactWarning && !isPriceImpactAccepted) return false
There was a problem hiding this comment.
In this hook, I like to take into account isPriceImpactAccepted value only when showPriceImpactWarning is true.
So, I can translate it as:
When price impact is shown, then take the "Price impact accepted" checkbox value into account
There was a problem hiding this comment.
But can it be showPriceImpactWarning and isFallbackHandlerRequired
in my proposal above it says, "if we show the price impact and is not accepted, return false, otherwise continue with the following logic" this way we consider other checks. If all check pass then we return true
Maybe I'm reading it wrong?
… fix/twap-handler-banner
Summary
To Test