Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.42]App navigates from Advanced to Swap page when change wallets #2771

Closed
elena-zh opened this issue Jun 30, 2023 · 2 comments
Closed

[1.42]App navigates from Advanced to Swap page when change wallets #2771

elena-zh opened this issue Jun 30, 2023 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP

Comments

@elena-zh
Copy link
Contributor

  1. Open Advanced orders page
  2. Connect to a wallet
  3. Open Account modal and press on the Change wallets button
  4. Change a wallet

AR: user is navigated to the Swap page

ER: user stays on the Advanced orders page
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP labels Jun 30, 2023
@elena-zh elena-zh mentioned this issue Jun 30, 2023
Merged
4 tasks
@nenadV91
Copy link
Contributor

nenadV91 commented Jul 6, 2023

Seems to be happening because of this code

cowswap/src/pages/AdvancedOrders/index.tsx

Line 17 in a13101c

if (!isAdvancedOrdersEnabled) {
. Once the flag is enabled this shouldn't be happening

@elena-zh elena-zh changed the title App navigates from Advanced to Swap page when change wallets [1.42]App navigates from Advanced to Swap page when change wallets Jul 13, 2023
@anxolin
Copy link
Contributor

anxolin commented Jul 17, 2023

@shoom3301 @nenadV91 closing if this is the case

@anxolin anxolin closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anxolin @nenadV91 @elena-zh