Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(twap-orders) add quote fetching loading indicator (6) #2451

Merged
merged 14 commits into from
May 22, 2023

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented May 11, 2023

Summary

This PR adds isLoading property on quote state
Also adds a hook that will return this value and we can use this for "nose picking cow" indicator

To test

  • when you change the currency or the amount there should be a nose picking cow indicator

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev 🔄 Building (Inspect) Visit Preview

🌃 Cosmos ↗︎

@elena-zh
Copy link
Contributor

I see the nose licking cow when I Select ETH/WETH (or vise versa) tokens. However, it is not displayed in the same case on the limit/swap pages

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@types/[email protected] None +0 types

@nenadV91 nenadV91 merged commit 7fc3e1d into feature/twap-orders-quote-1 May 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
@alfetopito alfetopito deleted the feature/twap-orders-quote-2 branch May 23, 2023 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants