feat(twap-orders): twap orders deadline updates (8)

[nenadV91]

Summary

• Lots of code refactoring
• Updates the deadline selector
• Adds display for single interval time
• Adds custom selector for TWAP orders
• Adds hooks to parse predefined intervals or custom intervals to single interval time

Custom deadline selector

Single interval time

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
swap-dev	🔄 Building (Inspect)	Visit Preview

🌃 Cosmos ↗︎

[socket-security]

New dependency changes detected. Learn more about Socket for GitHub ↗︎

---

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

---

📊 Modified Dependency Overview:

➕ Added Package	Capability Access	+/- Transitive Count	Publisher
@types/[email protected]	None	+0	types

[elena-zh]

Hey @nenadV91 , could you please provide a bit more information what should and what I should NOT test here?

[nenadV91]

@elena-zh I would just test the functionality in general and if you think something is not working properly let me know.

[elena-zh]

@elena-zh I would just test the functionality in general and if you think something is not working properly let me know.

Got it, thanks.
However, it would be great to clarify a bit about areas to test.
Not fond of an idea of testing something blindly, especially when I get answers that issues I report are not a part of this PR, this or that is not yet implemented, etc.
As an example of a great PR description is in #2462 ;)

[elena-zh]

Hey @nenadV91 , here are issues that I have faced:

1. Sometimes the tooltip overlaps the selector, so I can't press on the time in order to open the dropdown
   
2. When a part is less than 1 minute, the Part every section shows dash. The same issue is when a part should be 1 minute and some seconds
   
   
3. When I apply 0 minutes and 0 seconds, the dropdown shows 'Select time'. My proposal here is whether:

• not allow to set 0h and 0m,
• OR show a default value if 0h 0m is selected
  

4. Can we convert to days/hours/minutes when we select big numbers of hours and minutes (like it is done for Part every field)?
   
5. Can we keep the tooltip closer to the label in this case?
   
6. I can copy and paste a decimal value into the field, and the value will be saved. However, pre part value will be not correct:
   
   

Thank you!

[nenadV91]

@elena-zh

1. But the tooltip is removed when you move the mouse right?
2. Fixed, I've added seconds
3. Fixed, it will be disabled
4. Fixed
5. Fixed I think, the label wont break line now
6. Fixed, dots will be removed now on paste

[elena-zh]

Hey @nenadV91 , I have caught the app crash when I opened the Advanced orders tab