Add handled transition #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransition" so we know what kind of transition it is.
| if let geo = store.findById(region.identifier) { | ||
| if let notification = geo["notification"].asDictionary { | ||
| notifyAbout(geo) | ||
| } | ||
|
|
||
| NSNotificationCenter.defaultCenter().postNotificationName("handleTransition", object: geo.description) | ||
| var d = geo.description | ||
| d = d.substringToIndex(advance(d.startIndex, count(d) - 1)) + ",\"handledTransition\":\(type)}" |
There was a problem hiding this comment.
I think it would be better to just change fetched geofence object transitionType like geo["transitionType"] = type
|
I like it as well @tsubik , I didn't want to modify any existing data but i'm this is way more elegant than my solution. That said, we would have to change the json class on ios to enable modification of json variables. |
|
Ohh it is immutable. Duh |
|
It's better to leave those promises, you can use plugin as you like whether with promise or callback way. |
|
What this feature given up on ? |
|
Merged in #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a "handledTransition" property to be able to determine, for each geofence, the transition that was handled on the onTransition event (ENTER or EXIT). Might not be the best way to implement it, but it's working on iOS and Android