Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Identify Which Transition Type Occurred When Using TransitionType = 3 #49

Closed
jgcaruso opened this issue May 7, 2015 · 3 comments · Fixed by #97
Closed

Can't Identify Which Transition Type Occurred When Using TransitionType = 3 #49

jgcaruso opened this issue May 7, 2015 · 3 comments · Fixed by #97

Comments

@jgcaruso
Copy link

jgcaruso commented May 7, 2015

When using TransitionType = 3 there is not way to identify if it was an 'entered' or 'exited' event that triggered the event. Could the 'geo' object be modified in some way to identify if it was an Enter or Exit transition that triggered the current transition call?

The only way to currently detect this is to create separate Enter and Exit geofences, which on iOS uses up 2 of the 20 allowed fences (instead of just 1).

@jgcaruso
Copy link
Author

jgcaruso commented May 7, 2015

FYI I'm perfectly happy to implement this myself and submit a pull request, but if I do I want to make sure to implement it in a way that you're happy with. I considered updating the geo object that gets sent to the js and NotificationCenter listeners/handlers transitionType to 1 or 2 depending on which handler it came from (enter or exit), but if you'd rather not have it happen that way another property can be added to the geo object (something like actualTransitionType) with the appropriate number.

I just won't be able to implement this for Windows Phone because I am not really setup to develop for it.

@tsubik
Copy link
Member

tsubik commented May 8, 2015

Hey @jgcaruso your proposition to update transitionType in geo object is good. Don't worry about Windows Phone.

@raldred
Copy link

raldred commented May 14, 2015

👍 happy to assist as this is something i've just discovered also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants